From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 711213F12DE; Fri, 4 Sep 2026 13:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788529956; cv=none; b=djf4jEHGsCUmfuYSH+7A/9WdpfSO9OzMLuLjOOlgGv794qaVvvh0H/aHH7qGtW1xg+MFyTI8jXoFvtwxxIIiO8jSkSeivXJs7ugbMS/5Z3knDiAP/Doy9b5BDd1vu8qyH9h/M4dyRyxFKf3VvLXSWyM/8EPSte3ZrRs6OSibjrY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788529956; c=relaxed/simple; bh=U3BHcGzy0XpbIDqERAPq2BemblqMmpns070yQ0jg+UI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Yu0Z+1cMcczFEsGGBp3/Xpr2qs/JASXKhZXxrddvvMVQaMJ65Va9YJFJOp3qFsFbZziZIVBpZhyLFbPtuOdfccjI6VNP2zhhta9Ux0F87lyw97Ajsm38RQ4UcrAHoW3NqF/FrUpsbFguVxFdafizw8n8rjElxZIjiKG32lDeam0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gpBXPqMS; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gpBXPqMS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D8241F00A3D; Fri, 4 Sep 2026 13:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788529955; bh=JLgwTSSCpM3L6iDJ0ynlXolF/uJm18acCEZZpWdVymM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gpBXPqMS9xzgulJaIs2j+/CHJyl9XJXcCIVop/7FoAmnGIGxVjkGQ0Bt1M3HHXZU5 0szWoycEbq0vzieUVJayBYrhMw6lrAUWTc6CVrWItFRaUJ0/xyxyP21URl5HAjCeIi 4+GaztiJvJvT+NwE72sl5AVtstCxs2iD5F0AbxJpR/+6J1Sut+AuX+txXwkAs5nuhp tcprpCwS+eLJ442vVGtmiYiIo9ghEacZaF65eMZ8+KhzKuSL5qvzj2ATVyO78te9MD fJnbQO3t+DYnCJspgko0DhxABsc9yGxx9Q8/I/rjfE0mLelE175kHc8IY5hP0Ev8CR e0UlTKnHDPSnA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 11/19] soc: starfive: Add jh7110-hdmi-subsystem driver Reply-To: sashiko-reviews@lists.linux.dev To: "Michal Wilczynski" Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, lee@kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, vkoul@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260904-jh7110-clean-send-v3-11-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-11-484f9ae72715@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 04 Sep 2026 13:52:33 +0000 Message-Id: <20260904135234.5D8241F00A3D@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Incorrect regmap configuration (.val_bits =3D 8) forces byte-wise = accesses on a 32-bit register file, which may cause bus faults or ignored w= rites. -- commit 83ac96938fc0f15d53cdae0501c6e430a17c1c1d Author: Michal Wilczynski soc: starfive: Add jh7110-hdmi-subsystem driver This commit introduces a parent driver for the monolithic StarFive JH7110 HDMI IP block. It maps the shared register block and creates child devices for the PHY and controller using a shared regmap. > diff --git a/drivers/soc/starfive/jh7110-hdmi-subsystem.c b/drivers/soc/s= tarfive/jh7110-hdmi-subsystem.c > new file mode 100644 > index 0000000000000..e05b91825be4d > --- /dev/null > +++ b/drivers/soc/starfive/jh7110-hdmi-subsystem.c [ ... ] > +static const struct regmap_config starfive_hdmi_regmap_config =3D { > + .reg_bits =3D 32, > + .val_bits =3D 8, [Severity: High] Will this regmap configuration cause byte-wise memory accesses on a 32-bit register file?=20 Setting .val_bits =3D 8 forces the regmap core to use 8-bit readb()/writeb() accesses instead of 32-bit readl()/writel(). The underlying Innosilicon HDMI IP has registers spaced by 4 bytes and natively expects 32-bit accesses. On RISC-V platforms like the JH7110, byte-wise access to 32-bit APB peripherals typically triggers a Store/Load Access Fault or results in silently ignored writes. > + .max_register =3D 0x3fff, > +}; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260904-jh7110-cle= an-send-v3-0-484f9ae72715@samsung.com?part=3D11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6FBB9C61DD6 for ; Fri, 4 Sep 2026 13:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VXnhoGSSXcRKSMAhZJkvWLj1sUknXv/Q1TL1Aq5+bJU=; b=xjhjORmLBSNNKy 2CUkPBK3MAIPvW5Q8D4ghQqHcr7YpuHUMlFTToaqTLn/CCR0HEPlOHxzr6514ekdaJuJdJEIusVRL 5nhrV8xDl7FlXWr2aWIDdY4lIlnOCuUKXnxD5CjeFwjFPGNYkqz46t154cg7gmhTnq/bilVgvS9I0 RNcHzMT6iSncp8fedmifRFccHXIxGaEmRi9GKOO/OSTwG76qzB1UfS+kcT5zvizdX1onj0DCk5V16 4xWydS1jJEdmWUu/acPKPiZUzqF54CEnuHlWR5Owk9QyYQDVnNhQ4pQ4P2zYkNy6Xeh03qOIWDbrY tIg5CKQMwedJW7sPsOrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2ULM-00000002Hio-3j8l; Fri, 04 Sep 2026 13:52:37 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2ULM-00000002Hid-0Xyq for linux-phy@lists.infradead.org; Fri, 04 Sep 2026 13:52:36 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4AAE4601F0; Fri, 4 Sep 2026 13:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D8241F00A3D; Fri, 4 Sep 2026 13:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788529955; bh=JLgwTSSCpM3L6iDJ0ynlXolF/uJm18acCEZZpWdVymM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gpBXPqMS9xzgulJaIs2j+/CHJyl9XJXcCIVop/7FoAmnGIGxVjkGQ0Bt1M3HHXZU5 0szWoycEbq0vzieUVJayBYrhMw6lrAUWTc6CVrWItFRaUJ0/xyxyP21URl5HAjCeIi 4+GaztiJvJvT+NwE72sl5AVtstCxs2iD5F0AbxJpR/+6J1Sut+AuX+txXwkAs5nuhp tcprpCwS+eLJ442vVGtmiYiIo9ghEacZaF65eMZ8+KhzKuSL5qvzj2ATVyO78te9MD fJnbQO3t+DYnCJspgko0DhxABsc9yGxx9Q8/I/rjfE0mLelE175kHc8IY5hP0Ev8CR e0UlTKnHDPSnA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 11/19] soc: starfive: Add jh7110-hdmi-subsystem driver To: "Michal Wilczynski" Cc: dri-devel@lists.freedesktop.org, linux-clk@vger.kernel.org, lee@kernel.org, mfd@lists.linux.dev, linux-phy@lists.infradead.org, vkoul@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260904-jh7110-clean-send-v3-11-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-11-484f9ae72715@samsung.com> Date: Fri, 04 Sep 2026 13:52:33 +0000 Message-Id: <20260904135234.5D8241F00A3D@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIEluY29ycmVjdCByZWdt YXAgY29uZmlndXJhdGlvbiAoLnZhbF9iaXRzID0gOCkgZm9yY2VzIGJ5dGUtd2lzZSBhY2Nlc3Nl cyBvbiBhIDMyLWJpdCByZWdpc3RlciBmaWxlLCB3aGljaCBtYXkgY2F1c2UgYnVzIGZhdWx0cyBv ciBpZ25vcmVkIHdyaXRlcy4KLS0KCmNvbW1pdCA4M2FjOTY5MzhmYzBmMTVkNTNjZGFlMDUwMWM2 ZTQzMGExN2MxYzFkCkF1dGhvcjogTWljaGFsIFdpbGN6eW5za2kgPG0ud2lsY3p5bnNraUBzYW1z dW5nLmNvbT4Kc29jOiBzdGFyZml2ZTogQWRkIGpoNzExMC1oZG1pLXN1YnN5c3RlbSBkcml2ZXIK ClRoaXMgY29tbWl0IGludHJvZHVjZXMgYSBwYXJlbnQgZHJpdmVyIGZvciB0aGUgbW9ub2xpdGhp YyBTdGFyRml2ZSBKSDcxMTAKSERNSSBJUCBibG9jay4gSXQgbWFwcyB0aGUgc2hhcmVkIHJlZ2lz dGVyIGJsb2NrIGFuZCBjcmVhdGVzIGNoaWxkIGRldmljZXMKZm9yIHRoZSBQSFkgYW5kIGNvbnRy b2xsZXIgdXNpbmcgYSBzaGFyZWQgcmVnbWFwLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zb2Mv c3RhcmZpdmUvamg3MTEwLWhkbWktc3Vic3lzdGVtLmMgYi9kcml2ZXJzL3NvYy9zdGFyZml2ZS9q aDcxMTAtaGRtaS1zdWJzeXN0ZW0uYwo+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAw MDAwMDAwMDAwMC4uZTA1YjkxODI1YmU0ZAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJz L3NvYy9zdGFyZml2ZS9qaDcxMTAtaGRtaS1zdWJzeXN0ZW0uYwpbIC4uLiBdCj4gK3N0YXRpYyBj b25zdCBzdHJ1Y3QgcmVnbWFwX2NvbmZpZyBzdGFyZml2ZV9oZG1pX3JlZ21hcF9jb25maWcgPSB7 Cj4gKwkucmVnX2JpdHMgPSAzMiwKPiArCS52YWxfYml0cyA9IDgsCgpbU2V2ZXJpdHk6IEhpZ2hd CldpbGwgdGhpcyByZWdtYXAgY29uZmlndXJhdGlvbiBjYXVzZSBieXRlLXdpc2UgbWVtb3J5IGFj Y2Vzc2VzIG9uIGEgMzItYml0CnJlZ2lzdGVyIGZpbGU/IAoKU2V0dGluZyAudmFsX2JpdHMgPSA4 IGZvcmNlcyB0aGUgcmVnbWFwIGNvcmUgdG8gdXNlIDgtYml0IHJlYWRiKCkvd3JpdGViKCkKYWNj ZXNzZXMgaW5zdGVhZCBvZiAzMi1iaXQgcmVhZGwoKS93cml0ZWwoKS4gVGhlIHVuZGVybHlpbmcg SW5ub3NpbGljb24KSERNSSBJUCBoYXMgcmVnaXN0ZXJzIHNwYWNlZCBieSA0IGJ5dGVzIGFuZCBu YXRpdmVseSBleHBlY3RzIDMyLWJpdAphY2Nlc3Nlcy4KCk9uIFJJU0MtViBwbGF0Zm9ybXMgbGlr ZSB0aGUgSkg3MTEwLCBieXRlLXdpc2UgYWNjZXNzIHRvIDMyLWJpdCBBUEIKcGVyaXBoZXJhbHMg dHlwaWNhbGx5IHRyaWdnZXJzIGEgU3RvcmUvTG9hZCBBY2Nlc3MgRmF1bHQgb3IgcmVzdWx0cyBp bgpzaWxlbnRseSBpZ25vcmVkIHdyaXRlcy4KCj4gKwkubWF4X3JlZ2lzdGVyID0gMHgzZmZmLAo+ ICt9OwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRj aHNldC8yMDI2MDkwNC1qaDcxMTAtY2xlYW4tc2VuZC12My0wLTQ4NGY5YWU3MjcxNUBzYW1zdW5n LmNvbT9wYXJ0PTExCgotLSAKbGludXgtcGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwczovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1waHkK