From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3759CC624D3 for ; Fri, 4 Sep 2026 13:57:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8241F10F970; Fri, 4 Sep 2026 13:57:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="BOLEJpgc"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8E69D10F970 for ; Fri, 4 Sep 2026 13:57:10 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4148241834; Fri, 4 Sep 2026 13:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DFB1F00A3D; Fri, 4 Sep 2026 13:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788530230; bh=3vpS1tYpkPfcUSeqjetCrUKJtytc4S0Lgm4goTB6NAE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BOLEJpgcKjuxgddgJKzoW8b+Zl/njdDhxZhxVzDtCTnCULczgFtd2mulKVwRiB1Fz 179W3jsmHPb+6OLPabobQ0Uc4lkcKzKKrDDbJ1kKOF2hLZqEeW8J4/8VnOsTxHVqSQ +aRJg8Ickba024n3tdybJleJyckZvbIveO5LhBZVLDXg52Mg48e4sAtfFtrCdkCRmQ URapLvJR1BcH7uI/KyN5K+7vEU5+1x1xfPfj++MtpO1NwysaWotl6TSsXVx0yU/K9N 7QFY79EQkX1VslmtG+uFSy4Eei3i1RucYFqPzjmewbNT1Q1gY+FimhbhB9n4R8ySke dWu1wwDvYl50g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 14/19] drm/bridge: starfive: Add JH7110 HDMI controller driver To: "Michal Wilczynski" Cc: mfd@lists.linux.dev, robh@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, olteanv@gmail.com, conor+dt@kernel.org, lee@kernel.org, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, vkoul@kernel.org, linux-phy@lists.infradead.org In-Reply-To: <20260904-jh7110-clean-send-v3-14-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-14-484f9ae72715@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 04 Sep 2026 13:57:08 +0000 Message-Id: <20260904135709.41DFB1F00A3D@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [Medium] The `regmap` variable is assigned and checked but never used or = passed to the generic driver, contradicting the commit message. - [Medium] Missing mandatory `phy_init()` and `phy_exit()` calls for the HD= MI PHY. -- commit a25b9a0e71017577ee552276d0b9a0aa22a5f9f0 Author: Michal Wilczynski drm/bridge: starfive: Add JH7110 HDMI controller driver This commit adds the HDMI controller (bridge) driver for the StarFive JH7110. It registers as a DRM bridge, manages clock rates and PHY power, and configures the mux setting based on the port graph. > The driver calls the generic inno_hdmi_probe function and passes the > shared regmap to it, registering as a DRM bridge. [Severity: Medium] Is this description accurate regarding the regmap? Looking at the starfive_inno_hdmi_controller_probe() function below, the regmap is fetched but doesn't appear to actually be passed to inno_hdmi_probe() or used anywhere else. > diff --git a/drivers/gpu/drm/bridge/jh7110-inno-hdmi.c b/drivers/gpu/drm/= bridge/jh7110-inno-hdmi.c > new file mode 100644 > index 0000000000000..b0bf6abaa55fb > --- /dev/null > +++ b/drivers/gpu/drm/bridge/jh7110-inno-hdmi.c [ ... ] > +static void inno_hdmi_starfive_enable(struct device *dev, > + struct drm_display_mode *mode) > +{ [ ... ] > + /* > + * 3. Power on the PHY. This calls the PHY driver's .power_on op, > + * which configures the Post-PLL and analog blocks. > + */ > + ret =3D phy_power_on(ctrl->phy); [Severity: Medium] Does this code omit a required initialization step? The generic PHY API strictly requires phy_init() to be called before phy_power_on(). Even if the current starfive-inno-hdmi-phy driver lacks an .init callback, omitting phy_init() here violates the API contract and could lead to initialization failures if the PHY driver is updated or a different PHY is bound. > + if (ret) { > + dev_err(dev, "Failed to power on PHY: %d\n", ret); > + clk_disable_unprepare(ctrl->clks[CLK_PCLK].clk); > + return; > + } > + > + ctrl->enabled =3D true; > +} > + > +static void inno_hdmi_starfive_disable(struct device *dev) > +{ > + struct stf_inno_hdmi_controller *ctrl =3D dev_get_drvdata(dev); > + > + /* > + * .enable bails out early if the pixel clock rate is unsupported or > + * the PHY fails to power on, leaving pclk and the PHY untouched. > + * Only tear down what was actually brought up, otherwise the clock > + * refcount underflows. > + */ > + if (!ctrl->enabled) > + return; > + > + phy_power_off(ctrl->phy); [Severity: Medium] Should there be a call to phy_exit() here? Following the same API contract, phy_exit() should generally be invoked to clean up resources after phy_power_off() completes. > + clk_disable_unprepare(ctrl->clks[CLK_PCLK].clk); > + ctrl->enabled =3D false; > +} [ ... ] > +static int starfive_inno_hdmi_controller_probe(struct platform_device *p= dev) > +{ [ ... ] > + /* Get the shared regmap from the parent */ > + regmap =3D dev_get_regmap(parent, NULL); > + if (!regmap) { > + dev_err(dev, "Failed to get parent regmap\n"); > + return -ENODEV; > + } [Severity: Medium] Could this be dead code? The regmap is fetched and checked here, but subsequent code within starfive_inno_hdmi_controller_probe() never uses it. [ ... ] > + plat_data =3D of_device_get_match_data(dev); > + > + /* Hand off to the generic library to create the bridge. */ > + inno =3D inno_hdmi_probe(pdev, plat_data); [Severity: Medium] As mentioned regarding the commit message, should the regmap have been passed to inno_hdmi_probe() here? > + if (IS_ERR(inno)) > + return PTR_ERR(inno); > + > + return 0; > +} --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260904-jh7110-cle= an-send-v3-0-484f9ae72715@samsung.com?part=3D14 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA261C61DD6 for ; Fri, 4 Sep 2026 13:57:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=84sZnVwq86GN/rvLFOySTpiZNy21yRNqE5lhu+FycZQ=; b=R3krOeW4bBkxT0 bAbNGLZcpHJpkscR9crTaxAqFH57F/+Qfzu6BJgUFFMYRbXYx9wft6YJBjD2i7LydaO+qzas4IU07 PhAXBPM8KbEciN02s6A9Q0nRxdY1DL9ssNbVcnu2slXMAm9hW9opv4vMbcXFmV2bIMvF4uOKQJo6q FyN99YBoBa1M6QK2Fg740v2HxIxgSE3GM4Br5Gb+m2XEa3hJO8nl3yUNvPA+FQPZAGvf2pUXPNluB DlegY1PprUqmSG9aBfAqDD+CJ7ApHB3wpnbp9lbJBqSYwFnrOqthKMN4etLezTHnxlP7KZpkFBoCo +L0Y4exktqhmaJX59v5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2UPo-00000002Ii9-2AL1; Fri, 04 Sep 2026 13:57:12 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x2UPm-00000002Ihp-23Yf for linux-phy@lists.infradead.org; Fri, 04 Sep 2026 13:57:10 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4148241834; Fri, 4 Sep 2026 13:57:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41DFB1F00A3D; Fri, 4 Sep 2026 13:57:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788530230; bh=3vpS1tYpkPfcUSeqjetCrUKJtytc4S0Lgm4goTB6NAE=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BOLEJpgcKjuxgddgJKzoW8b+Zl/njdDhxZhxVzDtCTnCULczgFtd2mulKVwRiB1Fz 179W3jsmHPb+6OLPabobQ0Uc4lkcKzKKrDDbJ1kKOF2hLZqEeW8J4/8VnOsTxHVqSQ +aRJg8Ickba024n3tdybJleJyckZvbIveO5LhBZVLDXg52Mg48e4sAtfFtrCdkCRmQ URapLvJR1BcH7uI/KyN5K+7vEU5+1x1xfPfj++MtpO1NwysaWotl6TSsXVx0yU/K9N 7QFY79EQkX1VslmtG+uFSy4Eei3i1RucYFqPzjmewbNT1Q1gY+FimhbhB9n4R8ySke dWu1wwDvYl50g== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 14/19] drm/bridge: starfive: Add JH7110 HDMI controller driver To: "Michal Wilczynski" Cc: mfd@lists.linux.dev, robh@kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, olteanv@gmail.com, conor+dt@kernel.org, lee@kernel.org, dri-devel@lists.freedesktop.org, neil.armstrong@linaro.org, vkoul@kernel.org, linux-phy@lists.infradead.org In-Reply-To: <20260904-jh7110-clean-send-v3-14-484f9ae72715@samsung.com> References: <20260904-jh7110-clean-send-v3-0-484f9ae72715@samsung.com> <20260904-jh7110-clean-send-v3-14-484f9ae72715@samsung.com> Date: Fri, 04 Sep 2026 13:57:08 +0000 Message-Id: <20260904135709.41DFB1F00A3D@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIGByZWdtYXBg IHZhcmlhYmxlIGlzIGFzc2lnbmVkIGFuZCBjaGVja2VkIGJ1dCBuZXZlciB1c2VkIG9yIHBhc3Nl ZCB0byB0aGUgZ2VuZXJpYyBkcml2ZXIsIGNvbnRyYWRpY3RpbmcgdGhlIGNvbW1pdCBtZXNzYWdl LgotIFtNZWRpdW1dIE1pc3NpbmcgbWFuZGF0b3J5IGBwaHlfaW5pdCgpYCBhbmQgYHBoeV9leGl0 KClgIGNhbGxzIGZvciB0aGUgSERNSSBQSFkuCi0tCgpjb21taXQgYTI1YjlhMGU3MTAxNzU3N2Vl NTUyMjc2ZDBiOWEwYWEyMmE1ZjlmMApBdXRob3I6IE1pY2hhbCBXaWxjenluc2tpIDxtLndpbGN6 eW5za2lAc2Ftc3VuZy5jb20+CmRybS9icmlkZ2U6IHN0YXJmaXZlOiBBZGQgSkg3MTEwIEhETUkg Y29udHJvbGxlciBkcml2ZXIKClRoaXMgY29tbWl0IGFkZHMgdGhlIEhETUkgY29udHJvbGxlciAo YnJpZGdlKSBkcml2ZXIgZm9yIHRoZSBTdGFyRml2ZQpKSDcxMTAuIEl0IHJlZ2lzdGVycyBhcyBh IERSTSBicmlkZ2UsIG1hbmFnZXMgY2xvY2sgcmF0ZXMgYW5kIFBIWSBwb3dlciwKYW5kIGNvbmZp Z3VyZXMgdGhlIG11eCBzZXR0aW5nIGJhc2VkIG9uIHRoZSBwb3J0IGdyYXBoLgoKPiBUaGUgZHJp dmVyIGNhbGxzIHRoZSBnZW5lcmljIGlubm9faGRtaV9wcm9iZSBmdW5jdGlvbiBhbmQgcGFzc2Vz IHRoZQo+IHNoYXJlZCByZWdtYXAgdG8gaXQsIHJlZ2lzdGVyaW5nIGFzIGEgRFJNIGJyaWRnZS4K CltTZXZlcml0eTogTWVkaXVtXQpJcyB0aGlzIGRlc2NyaXB0aW9uIGFjY3VyYXRlIHJlZ2FyZGlu ZyB0aGUgcmVnbWFwPyBMb29raW5nIGF0IHRoZQpzdGFyZml2ZV9pbm5vX2hkbWlfY29udHJvbGxl cl9wcm9iZSgpIGZ1bmN0aW9uIGJlbG93LCB0aGUgcmVnbWFwIGlzIGZldGNoZWQKYnV0IGRvZXNu J3QgYXBwZWFyIHRvIGFjdHVhbGx5IGJlIHBhc3NlZCB0byBpbm5vX2hkbWlfcHJvYmUoKSBvciB1 c2VkCmFueXdoZXJlIGVsc2UuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L2poNzExMC1pbm5vLWhkbWkuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvamg3MTEwLWlubm8t aGRtaS5jCj4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi5iMGJm NmFiYWE1NWZiCj4gLS0tIC9kZXYvbnVsbAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv amg3MTEwLWlubm8taGRtaS5jClsgLi4uIF0KPiArc3RhdGljIHZvaWQgaW5ub19oZG1pX3N0YXJm aXZlX2VuYWJsZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gKwkJCQkgICAgICBzdHJ1Y3QgZHJtX2Rp c3BsYXlfbW9kZSAqbW9kZSkKPiArewpbIC4uLiBdCj4gKwkvKgo+ICsJICogMy4gUG93ZXIgb24g dGhlIFBIWS4gVGhpcyBjYWxscyB0aGUgUEhZIGRyaXZlcidzIC5wb3dlcl9vbiBvcCwKPiArCSAq IHdoaWNoIGNvbmZpZ3VyZXMgdGhlIFBvc3QtUExMIGFuZCBhbmFsb2cgYmxvY2tzLgo+ICsJICov Cj4gKwlyZXQgPSBwaHlfcG93ZXJfb24oY3RybC0+cGh5KTsKCltTZXZlcml0eTogTWVkaXVtXQpE b2VzIHRoaXMgY29kZSBvbWl0IGEgcmVxdWlyZWQgaW5pdGlhbGl6YXRpb24gc3RlcD8gVGhlIGdl bmVyaWMgUEhZIEFQSQpzdHJpY3RseSByZXF1aXJlcyBwaHlfaW5pdCgpIHRvIGJlIGNhbGxlZCBi ZWZvcmUgcGh5X3Bvd2VyX29uKCkuIEV2ZW4gaWYKdGhlIGN1cnJlbnQgc3RhcmZpdmUtaW5uby1o ZG1pLXBoeSBkcml2ZXIgbGFja3MgYW4gLmluaXQgY2FsbGJhY2ssIG9taXR0aW5nCnBoeV9pbml0 KCkgaGVyZSB2aW9sYXRlcyB0aGUgQVBJIGNvbnRyYWN0IGFuZCBjb3VsZCBsZWFkIHRvIGluaXRp YWxpemF0aW9uCmZhaWx1cmVzIGlmIHRoZSBQSFkgZHJpdmVyIGlzIHVwZGF0ZWQgb3IgYSBkaWZm ZXJlbnQgUEhZIGlzIGJvdW5kLgoKPiArCWlmIChyZXQpIHsKPiArCQlkZXZfZXJyKGRldiwgIkZh aWxlZCB0byBwb3dlciBvbiBQSFk6ICVkXG4iLCByZXQpOwo+ICsJCWNsa19kaXNhYmxlX3VucHJl cGFyZShjdHJsLT5jbGtzW0NMS19QQ0xLXS5jbGspOwo+ICsJCXJldHVybjsKPiArCX0KPiArCj4g KwljdHJsLT5lbmFibGVkID0gdHJ1ZTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgaW5ub19oZG1p X3N0YXJmaXZlX2Rpc2FibGUoc3RydWN0IGRldmljZSAqZGV2KQo+ICt7Cj4gKwlzdHJ1Y3Qgc3Rm X2lubm9faGRtaV9jb250cm9sbGVyICpjdHJsID0gZGV2X2dldF9kcnZkYXRhKGRldik7Cj4gKwo+ ICsJLyoKPiArCSAqIC5lbmFibGUgYmFpbHMgb3V0IGVhcmx5IGlmIHRoZSBwaXhlbCBjbG9jayBy YXRlIGlzIHVuc3VwcG9ydGVkIG9yCj4gKwkgKiB0aGUgUEhZIGZhaWxzIHRvIHBvd2VyIG9uLCBs ZWF2aW5nIHBjbGsgYW5kIHRoZSBQSFkgdW50b3VjaGVkLgo+ICsJICogT25seSB0ZWFyIGRvd24g d2hhdCB3YXMgYWN0dWFsbHkgYnJvdWdodCB1cCwgb3RoZXJ3aXNlIHRoZSBjbG9jawo+ICsJICog cmVmY291bnQgdW5kZXJmbG93cy4KPiArCSAqLwo+ICsJaWYgKCFjdHJsLT5lbmFibGVkKQo+ICsJ CXJldHVybjsKPiArCj4gKwlwaHlfcG93ZXJfb2ZmKGN0cmwtPnBoeSk7CgpbU2V2ZXJpdHk6IE1l ZGl1bV0KU2hvdWxkIHRoZXJlIGJlIGEgY2FsbCB0byBwaHlfZXhpdCgpIGhlcmU/IEZvbGxvd2lu ZyB0aGUgc2FtZSBBUEkgY29udHJhY3QsCnBoeV9leGl0KCkgc2hvdWxkIGdlbmVyYWxseSBiZSBp bnZva2VkIHRvIGNsZWFuIHVwIHJlc291cmNlcyBhZnRlcgpwaHlfcG93ZXJfb2ZmKCkgY29tcGxl dGVzLgoKPiArCWNsa19kaXNhYmxlX3VucHJlcGFyZShjdHJsLT5jbGtzW0NMS19QQ0xLXS5jbGsp Owo+ICsJY3RybC0+ZW5hYmxlZCA9IGZhbHNlOwo+ICt9ClsgLi4uIF0KPiArc3RhdGljIGludCBz dGFyZml2ZV9pbm5vX2hkbWlfY29udHJvbGxlcl9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ICt7ClsgLi4uIF0KPiArCS8qIEdldCB0aGUgc2hhcmVkIHJlZ21hcCBmcm9tIHRo ZSBwYXJlbnQgKi8KPiArCXJlZ21hcCA9IGRldl9nZXRfcmVnbWFwKHBhcmVudCwgTlVMTCk7Cj4g KwlpZiAoIXJlZ21hcCkgewo+ICsJCWRldl9lcnIoZGV2LCAiRmFpbGVkIHRvIGdldCBwYXJlbnQg cmVnbWFwXG4iKTsKPiArCQlyZXR1cm4gLUVOT0RFVjsKPiArCX0KCltTZXZlcml0eTogTWVkaXVt XQpDb3VsZCB0aGlzIGJlIGRlYWQgY29kZT8gVGhlIHJlZ21hcCBpcyBmZXRjaGVkIGFuZCBjaGVj a2VkIGhlcmUsIGJ1dApzdWJzZXF1ZW50IGNvZGUgd2l0aGluIHN0YXJmaXZlX2lubm9faGRtaV9j b250cm9sbGVyX3Byb2JlKCkgbmV2ZXIgdXNlcyBpdC4KClsgLi4uIF0KPiArCXBsYXRfZGF0YSA9 IG9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YShkZXYpOwo+ICsKPiArCS8qIEhhbmQgb2ZmIHRvIHRo ZSBnZW5lcmljIGxpYnJhcnkgdG8gY3JlYXRlIHRoZSBicmlkZ2UuICovCj4gKwlpbm5vID0gaW5u b19oZG1pX3Byb2JlKHBkZXYsIHBsYXRfZGF0YSk7CgpbU2V2ZXJpdHk6IE1lZGl1bV0KQXMgbWVu dGlvbmVkIHJlZ2FyZGluZyB0aGUgY29tbWl0IG1lc3NhZ2UsIHNob3VsZCB0aGUgcmVnbWFwIGhh dmUgYmVlbgpwYXNzZWQgdG8gaW5ub19oZG1pX3Byb2JlKCkgaGVyZT8KCj4gKwlpZiAoSVNfRVJS KGlubm8pKQo+ICsJCXJldHVybiBQVFJfRVJSKGlubm8pOwo+ICsKPiArCXJldHVybiAwOwo+ICt9 CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0 LzIwMjYwOTA0LWpoNzExMC1jbGVhbi1zZW5kLXYzLTAtNDg0ZjlhZTcyNzE1QHNhbXN1bmcuY29t P3BhcnQ9MTQKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXBoeQo=