Re: [PATCH v6 02/17] dt-bindings: iio: adc: Add AD7768

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding defines properties for a GPIO controller but fails to include `gpio-controller` and `#gpio-cells` in the `required` list.
--

commit bc42d987ad118f0b1686ed33657b36a45a4a5392
Author: Janani Sunil <janani.sunil@analog.com>

dt-bindings: iio: adc: Add AD7768

Devicetree Bindings for AD7768-4 (4 channel) and AD7768 (8 channel)
simultaneous sampling ADCs.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml
> new file mode 100644
> index 0000000000000..d8e489fa1f6ff
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7768.yaml

[ ... ]

> +  sync-in-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO connected to the SYNC_IN pin. Receives the synchronization pulse
> +      generated on SYNC_OUT in response to a START pulse. Must be synchronous
> +      to the MCLK clock domain. In multi-device or daisy-chained systems,
> +      two successive synchronization pulses must be applied to guarantee all
> +      ADCs are synchronized.
> +
> +  gpio-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  adi,data-lines-number:

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - avdd1-supply
> +  - avdd2-supply
> +  - iovdd-supply
> +  - ref1p-supply
> +  - ref2p-supply
> +  - io-backends

[Severity: Medium]
The binding defines gpio-controller and #gpio-cells earlier in the schema,
indicating the hardware has GPIO provider capabilities. Should these 
properties be added to this required list?

When hardware acts as a provider, the subsystem guidelines require the
corresponding standard properties to be explicitly listed as required.
Without this, incomplete device tree nodes that omit the GPIO properties
will silently pass schema validation, which might lead to runtime failures
if dependent devices attempt to use the GPIO functionality.

> +
> +allOf:
> +  - $ref: /schemas/spi/spi-peripheral-props.yaml#
> +  - if:

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904-ad7768-driver-v6-0-e4378f946bfb@analog.com?part=2