Re: [LTP] cpuset_memory_spread: count only the test file's page cache

[linuxtestproject.agent@gmail.com]

Hi Changwei,

On Sep 4, 2026, Changwei Zou wrote:
> cpuset_memory_spread: count only the test file's page cache

> +		if (query_pages_node(n, pages + off, status + off) == -1) {
> +			warn("move_pages failed");
> +			goto out;
> +		}

Medium: In Linux 7.3, move_pages() is built only when
CONFIG_NUMA_MIGRATION=y. With it disabled this returns ENOSYS, the helper
writes "0" to the FIFO, and every case reports TFAIL; require the config and
report missing syscall support as TCONF.

> +	# the unexpected nodes must hold only a negligible fraction
> +	if [ $((unexpected_sum * 100)) -ge $((total * UNEXPECTED_TOLERANCE)) ]; then
> +		return 1
> +	fi

Low: This rejects an unexpected share of exactly 5%, although the commit
message and comments say that "at most" 5% is allowed. Use -gt, or document
5% as an exclusive limit.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp