Re: [PATCH net-next v10 1/5] net: rnpgbe: Add interrupt handling

[Jakub Kicinski <kuba@kernel.org>]

On Mon, 31 Aug 2026 15:36:04 +0800 Dong Yibo wrote:
> +/**
> + * rnpgbe_int_single - MSI-X single-vector/MSI interrupt handler
> + * @irq: interrupt number
> + * @data: private data
> + *
> + * Return: IRQ_HANDLED
> + **/
> +static irqreturn_t rnpgbe_int_single(int irq, void *data)
> +{
> +	struct mucse *mucse = (struct mucse *)data;
> +	struct mucse_q_vector *q_vector;
> +
> +	queue_work(system_percpu_wq, &mucse->mbx_work);
> +
> +	if (test_bit(__MUCSE_DOWN, &mucse->state))
> +		return IRQ_HANDLED;
> +
> +	q_vector = mucse->q_vector[0];
> +	rnpgbe_irq_disable_queues(q_vector);
> +	napi_schedule_irqoff(&q_vector->napi);
> +
> +	return IRQ_HANDLED;
> +}

It's not reasonable to have a single IRQ handle datapath and also
unconditionally queue a mbox work item. Just require at least 2 IRQs.