All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Bobby Eshleman <bobbyeshleman@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>,
	Neal Cardwell <ncardwell@google.com>,
	Kuniyuki Iwashima <kuniyu@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stanislav Fomichev <sdf@fomichev.me>,
	Mina Almasry <almasrymina@google.com>, David Wei <dw@davidwei.uk>,
	Bobby Eshleman <bobbyeshleman@meta.com>
Subject: Re: [PATCH net-next] tcp: devmem: only pre-allocate tokens the receiver can consume
Date: Fri, 4 Sep 2026 15:11:46 -0700	[thread overview]
Message-ID: <20260904151146.602c61a4@kernel.org> (raw)
In-Reply-To: <20260902-b4-net-next_devmem-token-refill-v1-1-81d8990e5e17@meta.com>

On Wed, 02 Sep 2026 15:24:19 -0700 Bobby Eshleman wrote:
> Testing on a CX7 w/ GRO and a steady sendmsg() flow of 1MB per send, we
> see a typical RX-side skb touch upwards of ~32KB. With a 4KB recvmsg
> size, probing shows that ~75% of the allocated tokens are not used.

4kB seems unreasonably small. Is there a real life reason to use such
a small buffer / read length?

  reply	other threads:[~2026-09-04 22:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 22:24 [PATCH net-next] tcp: devmem: only pre-allocate tokens the receiver can consume Bobby Eshleman
2026-09-04 22:11 ` Jakub Kicinski [this message]
2026-09-04 22:44   ` Bobby Eshleman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904151146.602c61a4@kernel.org \
    --to=kuba@kernel.org \
    --cc=almasrymina@google.com \
    --cc=bobbyeshleman@gmail.com \
    --cc=bobbyeshleman@meta.com \
    --cc=davem@davemloft.net \
    --cc=dw@davidwei.uk \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuniyu@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sdf@fomichev.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.