All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	devel@lists.libvirt.org,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Daniel P. Berrangé" <berrange@redhat.com>,
	"Pierrick Bouvier" <pierrick.bouvier@oss.qualcomm.com>
Subject: [PULL v2 12/13] configure: correctly honour --disable-containers
Date: Fri,  4 Sep 2026 17:06:42 +0100	[thread overview]
Message-ID: <20260904160643.353833-13-berrange@redhat.com> (raw)
In-Reply-To: <20260904160643.353833-1-berrange@redhat.com>

The configure script originally only probed for 'runc' command
in order to handle cross-compilation containers. The Makefile
under tests/docker would then probe again when used.

In order to eliminate the additional probeing, we changed
configure in commit c4ce04cfb7460d46c0262d437a7f35bb5c5fc449
to always probe for 'runc', so the result could be passed
along to tests/docker make rules.

That commit overlooked that the 'probe_target_compiler' func
was relying on '$runc' == 'no' as a proxy for the state of
the --disable-containers arg.

When we started unconditionally probing, that short cut no
longer works and we must explicitly check "$use_containers"
too.

Fixes: c4ce04cfb7460d46c0262d437a7f35bb5c5fc449
Reported-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Tested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 46cbcc085b..d3ad7d4062 100755
--- a/configure
+++ b/configure
@@ -1414,6 +1414,7 @@ probe_target_compiler() {
   esac
 
   for host in $container_hosts; do
+    test "$use_containers" = "yes" || continue
     test "$container_command" != "" || continue
     test "$host" = "$cpu" || continue
     case $target_arch in
-- 
2.55.0



  parent reply	other threads:[~2026-09-04 16:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 16:06 [PULL v2 00/13] Misc fixes patches Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 01/13] crypto: Use g_autofree Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 02/13] crypto/x509-utils: don't double set errp Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 03/13] crypto/x509-utils: propagate the error Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 04/13] io/channel-socket: do not treat a zero length write as an error Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 05/13] io/channel-websock: send an HTTP 400 when the greeting has no space Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 06/13] io/channel-websock: handle a blocked write during the handshake Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 07/13] tests/unit: add websock handshake test Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 08/13] io/channel-websock: do not lose QIO_CHANNEL_ERR_BLOCK while reading Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 09/13] tests/unit: cover blocked IO during the websock handshake Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 10/13] crypto: deprecate the AF_ALG crypto backend Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 11/13] gitlab: use --emacs --quiet for checkpatch.pl instead of --terse Daniel P. Berrangé
2026-09-04 16:06 ` Daniel P. Berrangé [this message]
2026-09-07 10:48   ` [PULL v2 12/13] configure: correctly honour --disable-containers Daniel P. Berrangé
2026-09-04 16:06 ` [PULL v2 13/13] docs/system/security: exclude uninitialized stack variables as bugs Daniel P. Berrangé
2026-09-06 14:14 ` [PULL v2 00/13] Misc fixes patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904160643.353833-13-berrange@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=devel@lists.libvirt.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@oss.qualcomm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.