From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, Daniel Vacek <neelx@suse.com>
Subject: Re: [PATCH] btrfs: move async csum generation out of experimental features
Date: Fri, 4 Sep 2026 18:55:20 +0200 [thread overview]
Message-ID: <20260904165520.GM9053@twin.jikos.cz> (raw)
In-Reply-To: <700ba6c46da86ace18a502b43c5e61d16a556060.1788424754.git.wqu@suse.com>
On Thu, Sep 03, 2026 at 06:09:41PM +0930, Qu Wenruo wrote:
> -static bool should_async_write(struct btrfs_bio *bbio)
> -{
> - struct btrfs_fs_info *fs_info = bbio->inode->root->fs_info;
> - bool auto_csum_mode = true;
> -
> -#ifdef CONFIG_BTRFS_EXPERIMENTAL
> - /*
> - * Write bios will calculate checksum and submit bio at the same time.
> - * Unless explicitly required don't offload serial csum calculate and bio
> - * submit into a workqueue.
> - */
> - return false;
> -#endif
> -
> - /* Submit synchronously if the checksum implementation is fast. */
> - if (auto_csum_mode && test_bit(BTRFS_FS_CSUM_IMPL_FAST, &fs_info->flags))
The fast csum implementation is not used anymore, so the
BTRFS_FS_CSUM_IMPL_FAST definition and related code can be deleted.
> - return false;
> -
> - /*
> - * Try to defer the submission to a workqueue to parallelize the
> - * checksum calculation unless the I/O is issued synchronously.
> - */
> - if (op_is_sync(bbio->bio.bi_opf))
> - return false;
> -
> - /* Zoned devices require I/O to be submitted in order. */
> - if ((bbio->bio.bi_opf & REQ_META) && btrfs_is_zoned(fs_info))
> - return false;
> -
> - return true;
> -}
next prev parent reply other threads:[~2026-09-04 16:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 8:39 [PATCH] btrfs: move async csum generation out of experimental features Qu Wenruo
2026-09-03 9:20 ` Daniel Vacek
2026-09-03 11:27 ` Qu Wenruo
2026-09-03 12:44 ` Daniel Vacek
2026-09-03 13:07 ` Daniel Vacek
2026-09-05 0:57 ` Qu Wenruo
2026-09-05 10:09 ` Daniel Vacek
2026-09-05 10:47 ` Qu Wenruo
2026-09-07 9:53 ` Daniel Vacek
2026-09-04 16:53 ` David Sterba
2026-09-04 16:55 ` David Sterba [this message]
2026-09-04 17:00 ` David Sterba
2026-09-04 22:21 ` Qu Wenruo
2026-09-07 9:59 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904165520.GM9053@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=neelx@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.