From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C247E2E8DEC for ; Fri, 4 Sep 2026 18:25:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.17 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788546306; cv=none; b=MmXu37sO5D3i68LNdBdsJHZa3M9UChoJujijQMYl3gtiC9EdH/7/nXj51cvCsRmBBgtk3Lj4ceZ2A1QzLrSixtBAOhXMaby7dsD4JlPQCWb7usIOb/EdfrYnL1MUnyuZIqOWw6kKJjsC1J4a1ldMDdPwEhViHUMVeinIJD1MXuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788546306; c=relaxed/simple; bh=CUpqq6qRObGcYk3wxitbh9xZgftrzhSFCXbeLoQsGFk=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QWbUHbaB19Xmyc4SxqF9JmYKalVokI2el8qTqSjtFLCzL4clCa0ZeR1EvELwIRBDiWHUP2h+ztQLN4FngCmxtY7fP9xCRs/64TxqWeMK/GceXd3EXhYlWFVJtWtZhm2XLVe9hlndh6pN1jpyGLQqX8ddB5ce22sVq5BTfsItDhc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=HviByQVs; arc=none smtp.client-ip=192.198.163.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="HviByQVs" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1788546305; x=1820082305; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=CUpqq6qRObGcYk3wxitbh9xZgftrzhSFCXbeLoQsGFk=; b=HviByQVs6wNa0s3/ySdsVaoVdJX1Y6/dOeDFLRRacb7XeCRMzh5EPao8 A1ZrvF2TSa5pTO8/wnVlaRB2G05DR3emKFYJs8wXMmiy9YQO5EiGbUXUa k64Ut5YHhV9/ZdvAOJAYP4AUawjfGJpStGsnXwWxieouLdaFWYCqk9BWT 0IbUKUSHR41HFjxAagFV4kzPBdn+uxRwrrotOX3H+RB8AIXUpRQ/o7UM9 1RZxQKgdeVhjmQhMAwUqNsVcMhhTyTjY+e3aWunSE9no7kgdxm3TeWmsG AzDVMtDFgO0EPN8TUuiIVy34uE7284QtIpABt5QPTYYZh0/xt+eHwa0zG w==; X-CSE-ConnectionGUID: hXxHxqaARkme0q/8v9+pPw== X-CSE-MsgGUID: EFq0BgodRXuXWw1N3Lid4w== X-IronPort-AV: E=McAfee;i="6800,10657,11896"; a="88932179" X-IronPort-AV: E=Sophos;i="6.25,262,1779174000"; d="scan'208";a="88932179" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2026 11:25:03 -0700 X-CSE-ConnectionGUID: 6ke9bNgvSmWoAi95/rpiNQ== X-CSE-MsgGUID: eZV3rnegSBqGyReXzhHNKA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,262,1779174000"; d="scan'208";a="294992455" Received: from mjruhl-vm.amr.corp.intel.com ([10.11.186.166]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2026 11:25:03 -0700 From: "Michael J. Ruhl" To: platform-driver-x86@vger.kernel.org, intel-xe@lists.freedesktop.org, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, matthew.brost@intel.com, rodrigo.vivi@intel.com, thomas.hellstrom@linux.intel.com, airlied@gmail.com, simona@ffwll.ch, david.e.box@linux.intel.com, anoop.c.vijay@intel.com, badal.nilawar@intel.com, matthew.d.roper@intel.com, james.ausmus@intel.com, karthik.poosa@intel.com Subject: [PATCH v6 01/18] platform/x86/intel/pmt: complete pcidev to device update Date: Fri, 4 Sep 2026 11:24:51 -0700 Message-ID: <20260904182451.1164868-21-michael.j.ruhl@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260904182451.1164868-20-michael.j.ruhl@intel.com> References: <20260904182451.1164868-20-michael.j.ruhl@intel.com> Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The update that moved struct pci_dev usage to struct device is incomplete. Only telemetry endpoints are covered. Other PMT features (crashlog) are now blocked from using the callback mechanism. Change struct intel_pmt_entry pci_dev member to device. Update callback usage to use the intel_pmt_entry rather than the telemetry endpoint. Fixes: 353042d54d82 ("platform/x86/intel/vsec: Switch exported helpers from pci_dev to device") Signed-off-by: Michael J. Ruhl --- drivers/platform/x86/intel/pmt/class.c | 5 ++--- drivers/platform/x86/intel/pmt/class.h | 3 +-- drivers/platform/x86/intel/pmt/discovery.c | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/intel/pmt/class.c index d0ab8e33c62a..402d51df834a 100644 --- a/drivers/platform/x86/intel/pmt/class.c +++ b/drivers/platform/x86/intel/pmt/class.c @@ -100,7 +100,7 @@ intel_pmt_read(struct file *filp, struct kobject *kobj, if (count > entry->size - off) count = entry->size - off; - count = pmt_telem_read_mmio(entry->ep->dev, entry->cb, entry->header.guid, buf, + count = pmt_telem_read_mmio(entry->dev, entry->cb, entry->header.guid, buf, entry->base, off, count); return count; @@ -286,8 +286,6 @@ static int pmt_resolve_access_pci(struct intel_pmt_entry *entry, return -EINVAL; } - entry->pcidev = pci_dev; - return 0; } @@ -365,6 +363,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_entry *entry, entry->guid = header->guid; entry->size = header->size; entry->cb = ivdev->priv_data; + entry->dev = ivdev->dev; return 0; } diff --git a/drivers/platform/x86/intel/pmt/class.h b/drivers/platform/x86/intel/pmt/class.h index a0ece4fc3837..258cb460e61c 100644 --- a/drivers/platform/x86/intel/pmt/class.h +++ b/drivers/platform/x86/intel/pmt/class.h @@ -20,7 +20,6 @@ #define GET_ADDRESS(v) ((v) & GENMASK(31, 3)) struct device; -struct pci_dev; extern struct class intel_pmt_class; struct telem_endpoint { @@ -42,7 +41,7 @@ struct intel_pmt_header { struct intel_pmt_entry { struct telem_endpoint *ep; - struct pci_dev *pcidev; + struct device *dev; struct intel_pmt_header header; u32 disc_header[PMT_DISC_DWORDS]; struct bin_attribute pmt_bin_attr; diff --git a/drivers/platform/x86/intel/pmt/discovery.c b/drivers/platform/x86/intel/pmt/discovery.c index c482368bfaae..f4203d240f54 100644 --- a/drivers/platform/x86/intel/pmt/discovery.c +++ b/drivers/platform/x86/intel/pmt/discovery.c @@ -609,7 +609,7 @@ void intel_pmt_get_features(struct intel_pmt_entry *entry) mutex_lock(&feature_list_lock); list_for_each_entry(feature, &pmt_feature_list, list) { - if (feature->priv->parent != entry->ep->dev) + if (feature->priv->parent != entry->dev) continue; pmt_get_features(entry, feature); -- 2.43.0