All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Nerijus Bendžiūnas" <nerijus.bendziunas@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>, linux-wireless@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/2] wifi: ath9k_htc: cope with lost WMI reads
Date: Fri,  4 Sep 2026 22:03:30 +0300	[thread overview]
Message-ID: <20260904190332.815525-1-nerijus.bendziunas@gmail.com> (raw)

On the USB devices every register read is a WMI round trip that can
time out, and ath9k_regread() reports a timeout as -1, the same as an
all-ones register. Two patches already on the list handle the reads
that caused the most damage: the spectral trigger no longer reads the
filter back [1], and a failed multi-read returns all ones [2].

Patch 1 stops ath9k_htc_calcrxfilter() reading AR_RX_FILTER and
AR_PHY_ERR back to find out whether a spectral scan set the PHY error
bits, and sets them from spec_priv instead. Patch 2 counts WMI commands
issued and timed out in a new debugfs file, so a timeout can be seen on
a kernel without debug output.

[1] https://lore.kernel.org/linux-wireless/20260904181709.788886-1-nerijus.bendziunas@gmail.com/
[2] https://lore.kernel.org/linux-wireless/20260904185253.809209-2-nerijus.bendziunas@gmail.com/

Changes in v2:
- Drop the length-drop counter patch from the series; it is sent on
  its own, it has nothing to do with WMI reads.
- Patch 2: the counter is named "Issued", it counts commands that were
  handed to the device.
- Add Assisted-by, rewrite the commit messages, rebase onto ath-next.

Nerijus Bendžiūnas (2):
  wifi: ath9k_htc: derive the PHY error filter bits from software state
  wifi: ath9k_htc: count WMI commands and timeouts in debugfs

 .../net/wireless/ath/ath9k/htc_drv_debug.c    | 25 +++++++++++++++++++
 drivers/net/wireless/ath/ath9k/htc_drv_txrx.c | 12 ++++-----
 drivers/net/wireless/ath/ath9k/wmi.c          |  2 ++
 drivers/net/wireless/ath/ath9k/wmi.h          |  2 ++
 4 files changed, 34 insertions(+), 7 deletions(-)


base-commit: 1d8e73163ef933624341075f576e2f36ef9133f7
-- 
2.55.0


             reply	other threads:[~2026-09-04 19:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 19:03 Nerijus Bendžiūnas [this message]
2026-09-04 19:03 ` [PATCH v2 1/2] wifi: ath9k_htc: derive the PHY error filter bits from software state Nerijus Bendžiūnas
2026-09-04 19:03 ` [PATCH v2 2/2] wifi: ath9k_htc: count WMI commands and timeouts in debugfs Nerijus Bendžiūnas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904190332.815525-1-nerijus.bendziunas@gmail.com \
    --to=nerijus.bendziunas@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.