From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jochen Behrens <jochen.behrens@broadcom.com>
Subject: [PATCH 7/7] net/vmxnet3: remove unused queue dump functions
Date: Fri, 4 Sep 2026 12:12:42 -0700 [thread overview]
Message-ID: <20260904191652.2399074-8-stephen@networkplumber.org> (raw)
In-Reply-To: <20260904191652.2399074-1-stephen@networkplumber.org>
vmxnet3_rxq_dump() and vmxnet3_txq_dump() are guarded by
RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED, a macro that is defined
nowhere and whose name records that the callers were removed long
ago. Building with the macro forced on only produces -Wunused-function warnings.
Remove the dead code.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 58 ------------------------------
1 file changed, 58 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index 552b8a9823..aaebfc8675 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -59,64 +59,6 @@
static int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t*, uint8_t);
static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *);
-#ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED
-static void vmxnet3_rxq_dump(struct vmxnet3_rx_queue *);
-static void vmxnet3_txq_dump(struct vmxnet3_tx_queue *);
-#endif
-
-#ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED
-static void
-vmxnet3_rxq_dump(struct vmxnet3_rx_queue *rxq)
-{
- uint32_t avail = 0;
-
- if (rxq == NULL)
- return;
-
- PMD_RX_LOG(DEBUG,
- "RXQ: cmd0 base : %p cmd1 base : %p comp ring base : %p.",
- rxq->cmd_ring[0].base, rxq->cmd_ring[1].base, rxq->comp_ring.base);
- PMD_RX_LOG(DEBUG,
- "RXQ: cmd0 basePA : 0x%lx cmd1 basePA : 0x%lx comp ring basePA : 0x%lx.",
- (unsigned long)rxq->cmd_ring[0].basePA,
- (unsigned long)rxq->cmd_ring[1].basePA,
- (unsigned long)rxq->comp_ring.basePA);
-
- avail = vmxnet3_cmd_ring_desc_avail(&rxq->cmd_ring[0]);
- PMD_RX_LOG(DEBUG,
- "RXQ:cmd0: size=%u; free=%u; next2proc=%u; queued=%u",
- (uint32_t)rxq->cmd_ring[0].size, avail,
- rxq->comp_ring.next2proc,
- rxq->cmd_ring[0].size - avail);
-
- avail = vmxnet3_cmd_ring_desc_avail(&rxq->cmd_ring[1]);
- PMD_RX_LOG(DEBUG, "RXQ:cmd1 size=%u; free=%u; next2proc=%u; queued=%u",
- (uint32_t)rxq->cmd_ring[1].size, avail, rxq->comp_ring.next2proc,
- rxq->cmd_ring[1].size - avail);
-
-}
-
-static void
-vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq)
-{
- uint32_t avail = 0;
-
- if (txq == NULL)
- return;
-
- PMD_TX_LOG(DEBUG, "TXQ: cmd base : %p comp ring base : %p data ring base : %p.",
- txq->cmd_ring.base, txq->comp_ring.base, txq->data_ring.base);
- PMD_TX_LOG(DEBUG, "TXQ: cmd basePA : 0x%lx comp ring basePA : 0x%lx data ring basePA : 0x%lx.",
- (unsigned long)txq->cmd_ring.basePA,
- (unsigned long)txq->comp_ring.basePA,
- (unsigned long)txq->data_ring.basePA);
-
- avail = vmxnet3_cmd_ring_desc_avail(&txq->cmd_ring);
- PMD_TX_LOG(DEBUG, "TXQ: size=%u; free=%u; next2proc=%u; queued=%u",
- (uint32_t)txq->cmd_ring.size, avail,
- txq->comp_ring.next2proc, txq->cmd_ring.size - avail);
-}
-#endif
static void
vmxnet3_tx_cmd_ring_release_mbufs(vmxnet3_cmd_ring_t *ring)
--
2.53.0
prev parent reply other threads:[~2026-09-04 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:12 [PATCH 0/7] fix XXX_DEBUG warnings Stephen Hemminger
2026-09-04 19:12 ` [PATCH 1/7] bus/fslmc: fix build of qbman debug code Stephen Hemminger
2026-09-10 16:51 ` hemant.agrawal
2026-09-04 19:12 ` [PATCH 2/7] bus/fslmc: fix signed comparison in buffer acquire Stephen Hemminger
2026-09-11 5:00 ` Hemant Agrawal
2026-09-04 19:12 ` [PATCH 3/7] crypto/caam_jr: fix descriptor dump build Stephen Hemminger
2026-09-11 5:01 ` Hemant Agrawal
2026-09-04 19:12 ` [PATCH 4/7] crypto/ipsec_mb: fix missing header for debug build Stephen Hemminger
2026-09-04 19:12 ` [PATCH 5/7] power/amd_uncore: fix debug log build Stephen Hemminger
2026-09-04 19:12 ` [PATCH 6/7] net/rnp: fix register debug log format Stephen Hemminger
2026-09-04 19:12 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904191652.2399074-8-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=jochen.behrens@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.