From: sashiko-bot@kernel.org
To: "Siddharth Chintamaneni" <sidchintamaneni@gmail.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
bpf@vger.kernel.org, "Alexander Gordeev" <agordeev@linux.ibm.com>
Subject: Re: [PATCH bpf-next v1 1/7] bpf: Fix timed may_goto stack pointer for private stacks
Date: Fri, 04 Sep 2026 19:58:19 +0000 [thread overview]
Message-ID: <20260904195819.DBC5E1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260904195132.141068-2-sidchintamaneni@gmail.com>
> timed may_goto passes a stack offset to the architecture trampoline,
> which reconstructs the counter pointer from its BPF frame pointer. This
> breaks when the JIT uses a private stack with a different frame pointer.
>
> Resolve the counter pointer in the fixup using BPF_REG_FP and pass the
> pointer through BPF_REG_AX. Account for the extra instruction in the
> internal branch offsets.
>
> Fixes: e723608bf428 ("bpf: Add verifier support for timed may_goto")
> Reported-by: Jeremy Jean <jeremy.jean@oss.cyber.gouv.fr>
> Link: https://lore.kernel.org/all/20260824213158.3755932-2-Jeremy.Jean@oss.cyber.gouv.fr/
> Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260904195132.141068-1-sidchintamaneni@gmail.com?part=1
next prev parent reply other threads:[~2026-09-04 19:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 19:51 [PATCH bpf-next v1 0/7] Fix timed may_goto with private stacks Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 19:51 ` [PATCH bpf-next v1 1/7] bpf: Fix timed may_goto stack pointer for " Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 19:58 ` sashiko-bot [this message]
2026-09-04 19:51 ` [PATCH bpf-next v1 2/7] bpf, x86: Use resolved pointer for timed may_goto Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 20:02 ` sashiko-bot
2026-09-04 20:33 ` bot+bpf-ci
2026-09-04 20:33 ` bot+bpf-ci
2026-09-09 16:34 ` Siddharth Chintamaneni
2026-09-09 16:34 ` Siddharth Chintamaneni
2026-09-04 19:51 ` [PATCH bpf-next v1 3/7] bpf, arm64: " Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 20:01 ` sashiko-bot
2026-09-04 19:51 ` [PATCH bpf-next v1 4/7] bpf, powerpc64: " Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 19:58 ` sashiko-bot
2026-09-04 19:51 ` [PATCH bpf-next v1 5/7] bpf, riscv: " Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 19:57 ` sashiko-bot
2026-09-04 20:33 ` bot+bpf-ci
2026-09-04 20:33 ` bot+bpf-ci
2026-09-04 19:51 ` [PATCH bpf-next v1 6/7] bpf, s390: " Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 19:59 ` sashiko-bot
2026-09-04 20:33 ` bot+bpf-ci
2026-09-04 20:33 ` bot+bpf-ci
2026-09-04 19:51 ` [PATCH bpf-next v1 7/7] selftests/bpf: Test timed may_goto with private stacks Siddharth Chintamaneni
2026-09-04 19:51 ` Siddharth Chintamaneni
2026-09-04 19:58 ` sashiko-bot
2026-09-21 3:48 ` [PATCH bpf-next v1 0/7] Fix " Kumar Kartikeya Dwivedi
2026-09-21 3:48 ` Kumar Kartikeya Dwivedi
2026-09-21 16:24 ` Siddharth Chintamaneni
2026-09-21 16:24 ` Siddharth Chintamaneni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904195819.DBC5E1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sidchintamaneni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.