Re: [PATCH v2] arm64: dts: mediatek: Add #{address,size}-cells to Chromium-based /firmware

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing '=' in property assignments for #address-cells and #size-cells causes a build failure.
--

commit 32a566c4dedbeab82eeb3c544e3cf871695f6990
Author: Brian Norris <briannorris@chromium.org>

arm64: dts: mediatek: Add #{address,size}-cells to Chromium-based /firmware

This commit adds #address-cells and #size-cells properties to the /firmware
node in various Chromium-based MediaTek device trees. This fixes a probe
failure for coreboot_table introduced by requiring #address-cells for
translating non-translatable addresses.

Closes: https://lore.kernel.org/all/aeKlYzTiL0OB1y3g@google.com/

> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 69cab9f9c5308..fa359440ed60e 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -22,6 +22,11 @@ chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	firmware {
> +		#address-cells <2>;
> +		#size-cells <2>;

[Severity: Low]
Are the '=' signs missing from these property assignments? Omitting them
typically causes a parsing syntax error in dtc, which will break the
make dtbs build for the mt8183-kukui platform.

> +	};
> +
>  	backlight_lcd0: backlight_lcd0 {
>  		compatible = "pwm-backlight";
>  		pwms = <&pwm0 0 500000>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904155621.v2.1.I33d1d66d4724587a981f706243cdc2f264670a40@changeid?part=1