All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Breno Rodrigues Alves" <breno3011alves@gmail.com>
Cc: media-ci@linuxtv.org, linux-clk@vger.kernel.org,
	linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
	linux-pci@vger.kernel.org
Subject: Re: [PATCH v3] Kconfig: fix typos in core makefiles/code and purge remaining ghosts (v3)
Date: Sat, 05 Sep 2026 00:14:38 +0000	[thread overview]
Message-ID: <20260905001439.229131F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260905000655.103429-1-breno3011alves@gmail.com>

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Medium] The patch completely fails to include the changes described in the commit message. The intended C, Makefile, and Kconfig changes were not staged.
- [Low] The deletion of `lcd-panel-cgram.rst` leaves dangling file references in the MAINTAINERS file and translation indexes, which will break maintainer scripts and documentation builds.
- [Low] The deleted documentation file describes features for an active driver and should not have been removed as 'ghost weight'.
--

commit ffbb32c7781c62294c55f80e85430c46b71f5e34
Author: Breno Rodrigues Alves <breno3011alves@gmail.com>

Kconfig: fix typos in core makefiles/code and purge remaining ghosts (v3)

This patch intends to correct various typos in Makefiles and C code, clean up
Kconfig files, and remove remaining ghost weight. It modifies the admin-guide
index and removes the lcd-panel-cgram documentation.

>     This patch:
>       - Fixes MediaTek interconnect typo mapping mt8196.o to MT8195.
>       - Fixes MediaTek regulator typo mapping mt6316-regulator to MT6315.
>       - Fixes missing CONFIG_ prefix on DVB_ULE_DEBUG macro in dvb_net.c.
>       - Retains critical PCI_IMX6_EP and Tegra audio prompts to keep hidden
>         symbols selectable.
>       - Cleans up the dangling comment in drivers/leds/Kconfig.
>       - Purges the remaining verified ghost weight.

[Severity: Medium]
Did the actual code changes get omitted from this patch? 

The diff only touches documentation files (index.rst and lcd-panel-cgram.rst),
and none of the mentioned Makefile, C, or Kconfig modifications are present
in the staged changes.

> diff --git a/Documentation/admin-guide/lcd-panel-cgram.rst b/Documentation/admin-guide/lcd-panel-cgram.rst
> deleted file mode 100644
> index a3eb00c62f532..0000000000000
> --- a/Documentation/admin-guide/lcd-panel-cgram.rst
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -======================================
> -Parallel port LCD/Keypad Panel support
> -======================================

[Severity: Low]
Does this file describe features for an active driver rather than ghost
weight? 

The documentation appears to describe the active parallel LCD and keypad panel
driver located in drivers/auxdisplay/panel.c. 

Should this documentation be retained?

[Severity: Low]
Does removing this documentation leave dangling references elsewhere in the
tree? 

The MAINTAINERS file still lists this file under the PARALLEL LCD/KEYPAD
PANEL DRIVER section, which will cause maintainer script failures.

Additionally, there are still references to lcd-panel-cgram in the translation
indexes under Documentation/translations/zh_CN/admin-guide/index.rst and
Documentation/translations/zh_TW/admin-guide/index.rst.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905000655.103429-1-breno3011alves@gmail.com?part=1

      reply	other threads:[~2026-09-05  0:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05  0:06 [PATCH v3] Kconfig: fix typos in core makefiles/code and purge remaining ghosts (v3) Breno Rodrigues Alves
2026-09-05  0:14 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260905001439.229131F00A3D@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=breno3011alves@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=media-ci@linuxtv.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.