From: mdshahid03@gmail.com
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-iio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Mohammad Shahid" <mdshahid03@gmail.com>
Subject: [PATCH v3 6/6] iio: adc: bcm_iproc_adc: use devm_iio_device_register()
Date: Sat, 5 Sep 2026 15:06:31 +0530 [thread overview]
Message-ID: <20260905093631.48667-7-mdshahid03@gmail.com> (raw)
In-Reply-To: <20260905093631.48667-1-mdshahid03@gmail.com>
From: Mohammad Shahid <mdshahid03@gmail.com>
Use devm_iio_device_register() to automatically unregister the IIO
device when the device is detached.
This removes the manual iio_device_unregister() call and makes the
iproc_adc_remove() callback unnecessary.
Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
---
drivers/iio/adc/bcm_iproc_adc.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index f4676607682b..6eae7596ac8d 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -524,7 +524,6 @@ static int iproc_adc_probe(struct platform_device *pdev)
return -ENOMEM;
adc_priv = iio_priv(indio_dev);
- platform_set_drvdata(pdev, indio_dev);
ret = devm_mutex_init(dev, &adc_priv->mutex);
if (ret)
@@ -572,19 +571,8 @@ static int iproc_adc_probe(struct platform_device *pdev)
indio_dev->channels = iproc_adc_iio_channels;
indio_dev->num_channels = ARRAY_SIZE(iproc_adc_iio_channels);
- ret = iio_device_register(indio_dev);
- if (ret)
- return dev_err_probe(dev, ret, "iio_device_register failed\n");
-
- return 0;
-
-}
-
-static void iproc_adc_remove(struct platform_device *pdev)
-{
- struct iio_dev *indio_dev = platform_get_drvdata(pdev);
+ return devm_iio_device_register(dev, indio_dev);
- iio_device_unregister(indio_dev);
}
static const struct of_device_id iproc_adc_of_match[] = {
@@ -595,7 +583,6 @@ MODULE_DEVICE_TABLE(of, iproc_adc_of_match);
static struct platform_driver iproc_adc_driver = {
.probe = iproc_adc_probe,
- .remove = iproc_adc_remove,
.driver = {
.name = "iproc-static-adc",
.of_match_table = iproc_adc_of_match,
--
2.43.0
prev parent reply other threads:[~2026-09-05 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 9:36 [PATCH v3 0/6] iio: adc: bcm_iproc_adc: convert to devm-managed APIs mdshahid03
2026-09-05 9:36 ` [PATCH v3 1/6] iio: adc: bcm_iproc_adc: sort headers alphabetically mdshahid03
2026-09-05 9:36 ` [PATCH v3 2/6] iio: adc: bcm_iproc_adc: fix include dependencies mdshahid03
2026-09-05 23:33 ` Jonathan Cameron
2026-09-05 9:36 ` [PATCH v3 3/6] iio: adc: bcm_iproc_adc: use devm-managed clock mdshahid03
2026-09-05 23:33 ` Jonathan Cameron
2026-09-05 9:36 ` [PATCH v3 4/6] iio: adc: bcm_iproc_adc: use devm-managed ADC cleanup mdshahid03
2026-09-05 23:33 ` Jonathan Cameron
2026-09-05 9:36 ` [PATCH v3 5/6] iio: adc: bcm_iproc_adc: use devm-managed mutex initialization mdshahid03
2026-09-05 9:36 ` mdshahid03 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260905093631.48667-7-mdshahid03@gmail.com \
--to=mdshahid03@gmail.com \
--cc=andy@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.