Re: [PATCH 7/7] arm64: dts: qcom: ideacentre-mini: Drop the unused USB MP port

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete removal of the second USB MP port leaves unused interrupts in the device tree, causing dwc3-qcom to incorrectly detect 2 ports.
--

commit 60ea82fd4a9cce2b2f56bfccffd8337ca1f4e46b
Author: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

arm64: dts: qcom: ideacentre-mini: Drop the unused USB MP port

This commit drops the unused USB MP port by removing its repeater, reset
pin, and second MP PHYs from the device tree. It also pins the controller
to only use the first set of PHYs to avoid claiming empty PHYs.

> diff --git a/arch/arm64/boot/dts/qcom/x1-lenovo-ideacentre-mini-01q8x10.dtsi b/arch/arm64/boot/dts/qcom/x1-lenovo-ideacentre-mini-01q8x10.dtsi
> index 5a2db91d5e587..b720622c5d90e 100644
> --- a/arch/arm64/boot/dts/qcom/x1-lenovo-ideacentre-mini-01q8x10.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1-lenovo-ideacentre-mini-01q8x10.dtsi
[ ... ]
> @@ -1184,6 +1163,9 @@ usb_1_ss2_qmpphy_out_dp: endpoint@0 {
>  
>  &usb_mp {
>  	status = "okay";
> +
> +	phys = <&usb_mp_hsphy0>, <&usb_mp_qmpphy0>;
> +	phy-names = "usb2-0", "usb3-0";

[Severity: Medium]
Since the dwc3-qcom driver determines the number of active ports by counting
the dp_hs_phy_%d interrupts defined in the device tree, will this incomplete
override cause the driver to still detect two ports?

Because the interrupts-extended and interrupt-names properties inherited from
the base SoC dtsi are not overridden here, dp_hs_phy_2 and the other
second-port interrupts remain present.

During system suspend, could this lead to dwc3_qcom_suspend() polling the
unpopulated PHY and mistakenly enabling wakeup interrupts for the missing
port's floating lines? This might cause spurious wakeups or interrupt storms
that prevent deep sleep. Should the interrupt properties be overridden here
as well to drop the second port's interrupts?

>  };
>  
>  &usb_mp_hsphy0 {
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905-x1-ideacentre-mini-prettify-v1-0-9a87882973bb@oldschoolsolutions.biz?part=7