Re: [PATCH] PCI: eswin: Publish the platform driver's OF alias

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Resource leak of `perst` reset controls on the probe error path due to incorrect label ordering.
--

commit 086b34d1058711efceb6e05d5c137e933d166d8c
Author: hpp.iscas <hppiscas@163.com>

PCI: eswin: Publish the platform driver's OF alias

The ESWIN PCIe host controller is a platform driver matched through
eswin_pcie_of_match. PCIE_ESWIN is tristate, but the table is not
published for OF module autoloading.

Publish this platform-device table. Do not change the RISC-V host
initialization sequence or PCI device matching.

> diff --git a/drivers/pci/controller/dwc/pcie-eswin.c b/drivers/pci/controller/dwc/pcie-eswin.c
> index ce8d64f8a3957..1bb44696057e4 100644
> --- a/drivers/pci/controller/dwc/pcie-eswin.c
> +++ b/drivers/pci/controller/dwc/pcie-eswin.c
> @@ -388,6 +388,7 @@ static const struct of_device_id eswin_pcie_of_match[] = {
>  	{ .compatible = "eswin,eic7700-pcie", .data = &eswin_eic7700_data },
>  	{}
>  };
> +MODULE_DEVICE_TABLE(of, eswin_pcie_of_match);

[Severity: High]
This isn't a bug introduced by this patch, but while reviewing this file I
noticed a pre-existing issue in eswin_pcie_probe() regarding error handling.

When dw_pcie_host_init() fails, execution jumps to err_init:

	ret = dw_pcie_host_init(&pci->pp);
	if (ret) {
		dev_err(dev, "Failed to init host\n");
		goto err_init;
	}

Because err_init is positioned after err_pm_runtime_put, it completely skips
the loop that releases the exclusive perst reset controls:

err_pm_runtime_put:
	list_for_each_entry_safe(port, tmp, &pcie->ports, list) {
		reset_control_put(port->perst);
		list_del(&port->list);
	}
err_init:
	pm_runtime_put(dev);

Does this leak the perst reset controls?

Because they are requested exclusively via of_reset_control_get_exclusive(),
would subsequent attempts to reprobe the driver (e.g. module reload) fail to
acquire the reset controls until a full system reboot?

>  
>  static struct platform_driver eswin_pcie_driver = {
>  	.probe = eswin_pcie_probe,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905134251.67210-1-hppiscas@163.com?part=1