Re: [LTP] hugetlb/hugemmap: add hugemmap33 to test hugetlbfs quota accounting

[linuxtestproject.agent@gmail.com]

Hi Pavithra,

On September 5, 2026, Pavithra wrote:
> hugetlb/hugemmap: add hugemmap33 to test hugetlbfs quota accounting

> +/hugetlb/hugemmap/hugemmap33

New test binaries must be ignored by a .gitignore in their own directory.
Move this entry to testcases/kernel/mem/hugetlb/hugemmap/.gitignore as
/hugemmap33.

> +	TESTPTR(mmap(NULL, size, PROT_READ | PROT_WRITE, mmap_flags, fd, 0));
> +	if (TST_RET_PTR == MAP_FAILED) {
> +		tst_res(TFAIL | TERRNO, "mmap failed unexpectedly");

Use TST_EXP_PASS_PTR_VOID() for expected successes and
TST_EXP_FAIL_PTR_VOID(..., ENOMEM) for expected failures instead of manually
combining TESTPTR(), errno checks, and tst_res(). Keep only the cleanup logic
that depends on TST_PASS or TST_RET_PTR.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp