Re: [PATCH v8 04/43] drm: Mark CONFIG_DRM_USE_DYNAMIC_DEBUG as unBROKEN

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Undocumented behavior change: CONFIG_DRM_USE_DYNAMIC_DEBUG default changed from 'n' to 'y'
--

commit 953ce8d396d765b26b3da8e90da715679595b8c2
Author: Jim Cromie <jim.cromie@gmail.com>

drm: Mark CONFIG_DRM_USE_DYNAMIC_DEBUG as unBROKEN

This commit removes the BROKEN dependency on CONFIG_DRM_USE_DYNAMIC_DEBUG,
allowing the configuration to be enabled for testing dynamic-debug-enabled
DRM drivers.

> diff --git a/drivers/gpu/drm/Kconfig.debug b/drivers/gpu/drm/Kconfig.debug
> index 1f4c98cbf0906..2f05bab1a7965 100644
> --- a/drivers/gpu/drm/Kconfig.debug
> +++ b/drivers/gpu/drm/Kconfig.debug
> @@ -1,7 +1,6 @@
>  config DRM_USE_DYNAMIC_DEBUG
>  	bool "use dynamic debug to implement drm.debug"
> -	default n
> -	depends on BROKEN
> +	default y

[Severity: Medium]
The commit message mentions removing the BROKEN mark to allow enabling the
config, but it does not mention changing the default behavior to 'y'.

Since enabling this option introduces substantial .data overhead (~56 bytes
per callsite, resulting in hundreds of kilobytes of memory overhead for large
drivers like amdgpu), could changing the default to 'y' cause unintended
memory footprint regressions for any default kernel build with DRM and
DYNAMIC_DEBUG enabled?

Should this remain 'default n' so that developers can opt-in, or should the
justification for 'default y' be added to the commit message?

>  	depends on DRM
>  	depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE
>  	depends on JUMP_LABEL

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905-dd-cmap-part2-clean-v8-0-a4cc0674f6fd@gmail.com?part=4