All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Wajdeczko <michal.wajdeczko@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Gustavo Sousa <gustavo.sousa@intel.com>
Subject: [PATCH 1/2] drm/xe/tests: Fix default subplatform selection
Date: Sat,  5 Sep 2026 22:01:56 +0200	[thread overview]
Message-ID: <20260905200157.3164-2-michal.wajdeczko@intel.com> (raw)
In-Reply-To: <20260905200157.3164-1-michal.wajdeczko@intel.com>

If a test does not specify details about the fake device it wants
to create, our helper selects the device descriptor from the first
entry from the pciidlist and uses NULL for the subplatform descriptor.
While this works fine today, as the first device is a TGL which does
not have any subplatforms, it will be broken if we reorder pciidlist.

Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
---
Cc: Gustavo Sousa <gustavo.sousa@intel.com>
---
 drivers/gpu/drm/xe/tests/xe_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
index bb0393475524..a82cab7a2b86 100644
--- a/drivers/gpu/drm/xe/tests/xe_pci.c
+++ b/drivers/gpu/drm/xe/tests/xe_pci.c
@@ -351,7 +351,7 @@ int xe_pci_fake_device_init(struct xe_device *xe)
 
 	if (!data) {
 		desc = (const void *)ent->driver_data;
-		subplatform_desc = NULL;
+		subplatform_desc = desc->subplatforms;
 		goto done;
 	}
 
-- 
2.47.1


  reply	other threads:[~2026-09-05 20:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 20:01 [PATCH 0/2] drm/xe/tests: Fix subplatform selection Michal Wajdeczko
2026-09-05 20:01 ` Michal Wajdeczko [this message]
2026-09-09 19:04   ` [PATCH 1/2] drm/xe/tests: Fix default " Gustavo Sousa
2026-09-09 19:22     ` Michal Wajdeczko
2026-09-05 20:01 ` [PATCH 2/2] drm/xe/tests: Fix " Michal Wajdeczko
2026-09-09 19:13   ` Gustavo Sousa
2026-09-09 19:35     ` Michal Wajdeczko
2026-09-05 20:10 ` ✓ CI.KUnit: success for " Patchwork
2026-09-05 20:53 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-05 21:52 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260905200157.3164-2-michal.wajdeczko@intel.com \
    --to=michal.wajdeczko@intel.com \
    --cc=gustavo.sousa@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.