Re: [PATCH 1/2] perf thread: Fix live-session detection in thread__e_machine()

[sashiko-bot@kernel.org]

> When the per-thread e_machine cannot be determined from the DSOs in the
> thread's maps, thread__e_machine_endian() decides between reading
> /proc/<pid>/exe and falling back to the recorded session environment:
> 
> 	bool is_live = machine->machines == NULL;
> 
> 	if (!is_live) {
> 		/* Check if the session has a data file. */
> 		struct perf_session *session = container_of(...);
> 
> 		is_live = !!session->data;
> 	}
> 
> Neither half of that works.
> 
> [ ... ]
> machine__findnew_guest_code(), which machine__resolve() only calls when
> !machine__is_host(machine).
> 
> Fixes: 70351029b556 ("perf thread: Add support for reading the e_machine type for a thread")
> Signed-off-by: Matt Turner <mattst88@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260905-perf-alpha-annotate-v1-0-97380433ccb6@gmail.com?part=1