Re: [PATCH rtw-next v2 00/14] wifi: rtw89: update RTL8922D capabilities and settings, and enable P2P device

[Maxim Skokov <skokovmaksimevg@gmail.com>]

On Wed, Sep 02, 2026 at 01:29:44PM +0800, Ping-Ke Shih wrote:
> This series updates RTL8922D capabilities and settings, and enables
> P2P device.

Tested the chip-independent parts of this series on RTL8851BE
(rtw89_8851be), a 1x1 Wi-Fi 6 part, since patches 3 and 11-14 touch
common code and thus change behaviour for every rtw89 device.  The
8922d-specific patches (1-2, 4-10) were not exercised, I don't have
that hardware.

Applied on top of rtw-next commit 81510c3d6f21 ("wifi: rtw88: debugfs:
don't vzalloc(0) when rsvd_page is read unconfigured").  All 14 patches
applied cleanly and the build is free of new warnings.

Patch 3 and 14, interface combinations as reported by 'iw phy':

  before:
    #{ managed } <= 1, #{ AP, P2P-client, P2P-GO } <= 1,
    total <= 2, #channels <= 1

  after:
    #{ managed } <= 2, #{ AP, P2P-client, P2P-GO } <= 1,
    #{ P2P-device } <= 1, total <= 3, #channels <= 1

Patch 3, two station interfaces in SCC.  Second station vif added with
'iw interface add', given its own MAC and associated to the same BSSID
as the first one, so both links are on the same channel by construction
(5180 MHz).  Both associate, and both carry traffic at the same time:

  30 s of concurrent ping to the gateway, one flow per interface

    wlp2s0  90 packets transmitted, 90 received, 0% packet loss
    wlan1   90 packets transmitted, 90 received, 0% packet loss

  station dump after the run

    wlp2s0  rx 1225221  tx 27526  tx failed 1  beacon loss 15
    wlan1   rx  128239  tx 16140  tx failed 2  beacon loss  0

The first interface is unaffected when the second one is torn down.

Patch 14, P2P device.  wpa_supplicant creates it on its own during boot
now that the driver advertises the iftype, and NetworkManager lists it
as a wifi-p2p device.  The driver runs with three vifs at once
(two managed plus the P2P device) without complaints.

No WARNs, no backtraces and no rtw89 error messages in dmesg during any
of this.  Association, DHCP and switching between 2.4 GHz and 5 GHz all
keep working.

Patches 11-13 were only exercised indirectly, through the absence of
regressions in association and channel switching.  Patch 12 is a no-op
here, RTL8851BE has no 6 GHz band.

Tested-by: Maxim Skokov <skokovmaksimevg@gmail.com> # RTL8851BE, patches 3 and 11-14

One observation that may be worth a note in the cover letter.  Since
patch 14 declares #{ P2P-device } <= 1, a second wpa_supplicant instance
on the same phy cannot start: it tries to create its own P2P device,
hits the limit, and then gives up on the whole interface rather than
falling back:

  nl80211: Could not set interface 'p2p-dev-wlan1' UP
  P2P: Failed to enable P2P Device interface
  p2p-dev-wlan1: Failed to initialize driver interface

So the two-station setup that patch 3 enables needs p2p_disabled=1 in
the second supplicant config.  The driver behaves correctly here, it
just means the new capability is not reachable with a default
wpa_supplicant, which someone trying this out is likely to hit.

Thanks,
Maxim