From: sashiko-bot@kernel.org
To: "Ethan Nelson-Moore" <enelsonmoore@gmail.com>
Cc: linux-scsi@vger.kernel.org, cassel@kernel.org,
linux-ide@vger.kernel.org, linux-serial@vger.kernel.org,
dlemoal@kernel.org
Subject: Re: [PATCH] ecard: use module_driver() to avoid repeated boilerplate code
Date: Sun, 06 Sep 2026 04:06:41 +0000 [thread overview]
Message-ID: <20260906040642.27ECD1F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260906040153.105692-1-enelsonmoore@gmail.com>
> Many Acorn expansion card drivers have module_init and module_exit
> functions that only call ecard_register_driver() and
> ecard_remove_driver(). The module_driver() macro automatically
> generates these functions given the register and unregister functions.
> Switch to it to simplify the code.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260906040153.105692-1-enelsonmoore@gmail.com?part=1
next prev parent reply other threads:[~2026-09-06 4:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 4:01 [PATCH] ecard: use module_driver() to avoid repeated boilerplate code Ethan Nelson-Moore
2026-09-06 4:06 ` sashiko-bot [this message]
2026-09-06 10:16 ` Simon Horman
2026-09-07 2:12 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906040642.27ECD1F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=cassel@kernel.org \
--cc=dlemoal@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.