Re: [PATCH for-next 1/2] RDMA/hns: Limit gmv_entry_num to avoid memory waste

[Leon Romanovsky <leon@kernel.org>]

On Fri, Sep 04, 2026 at 05:38:36PM +0800, Junxian Huang wrote:
> The GMV entry is a HW object corresponding to a GID. Since gid_table_len
> is already limited to a maximum of 256, there is no need to allocate
> memory for those extra GMV entries as they will never be touched.
> 
> Fixes: 7243396aaf12 ("RDMA/hns: Add a max length of gid table")
> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com>
> ---
>  drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> index 27cc7df55ee7..3edceadbca76 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c
> @@ -2416,8 +2416,7 @@ static void apply_func_caps(struct hns_roce_dev *hr_dev)
>  					 caps->gmv_bt_num *
>  					 (HNS_HW_PAGE_SIZE / caps->gmv_entry_sz));
>  
> -		caps->gmv_entry_num = caps->gmv_bt_num * (HNS_HW_PAGE_SIZE /
> -							  caps->gmv_entry_sz);
> +		caps->gmv_entry_num = (u32)caps->gid_table_len[0];

Please fix the declaration of gid_table_len first. It should be u32 in the
first place.

Thanks

>  	} else {
>  		u32 func_num = max_t(u32, 1, hr_dev->func_num);
>  
> -- 
> 2.33.0
>