From: Donggeun Yoo <donggeunyoo.kernel@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-trace-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Tom Zanussi <zanussi@kernel.org>,
donggeunyoo.kernel@gmail.com
Subject: Re: [PATCH] tracing: hist: free the var ref when its initialization fails
Date: Sun, 6 Sep 2026 22:51:05 +0900 [thread overview]
Message-ID: <20260906135105.4092962-1-donggeunyoo.kernel@gmail.com> (raw)
In-Reply-To: <20260906134553.71E331F00A3A@smtp.kernel.org>
Sashiko wrote:
> - [High] Pre-existing memory leak in `__destroy_hist_field()` for variable
> references (`VAR_REF` fields) reused three or more times within a histogram
> trigger.
That is the bug fixed by the patch linked in this one's notes:
https://lore.kernel.org/linux-trace-kernel/20260906124025.3550596-1-donggeunyoo.kernel@gmail.com/
It removes the reference count so __destroy_hist_field() frees
unconditionally, and the three-reference case no longer leaks. The two
patches are independent and apply in either order.
next prev parent reply other threads:[~2026-09-06 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 13:33 [PATCH] tracing: hist: free the var ref when its initialization fails Donggeun Yoo
2026-09-06 13:45 ` sashiko-bot
2026-09-06 13:51 ` Donggeun Yoo [this message]
2026-09-10 1:10 ` Donggeun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906135105.4092962-1-donggeunyoo.kernel@gmail.com \
--to=donggeunyoo.kernel@gmail.com \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.