From: Deepanshu Kartikey <kartikey406@gmail.com>
To: cem@kernel.org, djwong@kernel.org
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Deepanshu Kartikey <kartikey406@gmail.com>,
syzbot+ccdf3469f5f653bff7ac@syzkaller.appspotmail.com
Subject: [PATCH] xfs: take hm->lock in xfs_ioc_health_monitor() before insert
Date: Sun, 6 Sep 2026 20:16:29 +0530 [thread overview]
Message-ID: <20260906144629.17009-1-kartikey406@gmail.com> (raw)
__xfs_healthmon_insert() asserts that hm->lock is held
(lockdep_assert_held), but xfs_ioc_health_monitor() called it right
after allocating hm, before ever taking the lock, triggering a
lockdep warning.
Take hm->lock around the call.
Fixes: b3a289a2a9397 ("xfs: create event queuing, formatting, and discovery infrastructure")
Reported-by: syzbot+ccdf3469f5f653bff7ac@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=ccdf3469f5f653bff7ac
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
---
fs/xfs/xfs_healthmon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/xfs/xfs_healthmon.c b/fs/xfs/xfs_healthmon.c
index 3ae5f4496ad1..2f762f90d329 100644
--- a/fs/xfs/xfs_healthmon.c
+++ b/fs/xfs/xfs_healthmon.c
@@ -1219,7 +1219,9 @@ xfs_ioc_health_monitor(
}
running_event->type = XFS_HEALTHMON_RUNNING;
running_event->domain = XFS_HEALTHMON_MOUNT;
+ mutex_lock(&hm->lock);
__xfs_healthmon_insert(hm, running_event);
+ mutex_unlock(&hm->lock);
/*
* Preallocate the unmount event so that we can't fail to notify the
--
2.34.1
next reply other threads:[~2026-09-06 14:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 14:46 Deepanshu Kartikey [this message]
2026-09-07 4:51 ` [PATCH] xfs: take hm->lock in xfs_ioc_health_monitor() before insert Darrick J. Wong
2026-09-10 5:07 ` Christoph Hellwig
2026-09-10 6:22 ` Carlos Maiolino
2026-09-10 6:23 ` Carlos Maiolino
2026-09-10 9:40 ` Carlos Maiolino
2026-09-10 13:42 ` Shigeru Yoshida
2026-09-10 14:33 ` Carlos Maiolino
2026-09-10 9:11 ` Carlos Maiolino
2026-09-11 7:29 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906144629.17009-1-kartikey406@gmail.com \
--to=kartikey406@gmail.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=syzbot+ccdf3469f5f653bff7ac@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.