From: sashiko-bot@kernel.org
To: wen.yang@linux.dev
Cc: linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v5 1/5] rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type
Date: Sun, 06 Sep 2026 17:18:02 +0000 [thread overview]
Message-ID: <20260906171802.A50EE1F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <a43e36b73cad69d7e9f26f234b97733c8e74e495.1788705281.git.wen.yang@linux.dev>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message claims to add documentation, but the patch does not modify any documentation files.
--
commit 9f88f295cb2517cf173e24803d40575bacb352d6
Author: Wen Yang <wen.yang@linux.dev>
rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type
This patch changes the reactor lockdep wait type override from LD_WAIT_FREE
to LD_WAIT_SPIN to prevent false-positive "Invalid wait context" warnings.
This resolves issues when preempting code, like the scheduler, takes spinlocks
while a reactor callback is running.
> Use LD_WAIT_SPIN instead of LD_WAIT_FREE, which causes false-positive
> warnings in preemptible contexts due to scheduler preemption taking
> rq->__lock. Add documentation to runtime-verification.rst.
[Severity: Low]
The commit message explicitly claims to add documentation to
runtime-verification.rst to describe the LD_WAIT_SPIN logic change made in
rv_react() (kernel/trace/rv/rv_reactors.c).
However, looking at the patch, no documentation files are actually modified.
Was the documentation update for this change accidentally dropped from the
commit?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1788705281.git.wen.yang@linux.dev?part=1
next prev parent reply other threads:[~2026-09-06 17:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 17:10 [PATCH v5 0/5] rv/reactors: fix lockdep warning and add tests wen.yang
2026-09-06 17:10 ` [PATCH v5 1/5] rv/reactors: use LD_WAIT_SPIN as the reactor lockdep wait type wen.yang
2026-09-06 17:18 ` sashiko-bot [this message]
2026-09-06 17:10 ` [PATCH v5 2/5] rv/reactors: propagate rv_register_reactor() error from reactor init wen.yang
2026-09-06 17:10 ` [PATCH v5 3/5] rv/reactors: export rv_register_reactor() and rv_unregister_reactor() wen.yang
2026-09-11 6:53 ` Gabriele Monaco
2026-09-13 16:33 ` Wen Yang
2026-09-06 17:10 ` [PATCH v5 4/5] rv/reactors: add KUnit tests for reactor registration and dispatch wen.yang
2026-09-06 17:23 ` sashiko-bot
2026-09-06 17:10 ` [PATCH v5 5/5] selftests/verification: Test loadable module-based reactor wen.yang
2026-09-06 17:19 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260906171802.A50EE1F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wen.yang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.