Re: [PATCH v4 1/3] tools: port perf ui from GTK 2 to GTK 4

[sashiko-bot@kernel.org]

> Port straight to GTK 4 rather than the intermediate GTK 3, since GTK 4
> is where new development happens and GTK 3 is now old itself.
> 
> GTK 4 removes GtkContainer, GdkScreen, and the gtk_main()/
> gtk_dialog_run() family perf's GTK UI relied on, so this is more than a
> mechanical rename: containers get per-widget setters (gtk_box_append()
> and friends), monitor geometry comes from GdkMonitor instead of
> GdkScreen, and the main and error-dialog loops become explicit
> GMainLoops, quit from the "close-request" and "response" signals since
> gtk_main_quit() and gtk_dialog_run() no longer exist. Widgets are
> visible by default now too, so gtk_widget_show_all()/set_no_show_all()
> go away.
> 
> gtk_ui_progress__finish() also skips destroying a progress dialog that
> was never created, since gtk_window_destroy() asserts on NULL/non-window
> [ ... ]
> since gtk_info_bar_new() is deprecated and the check treats deprecation
> warnings as errors. HAVE_GTK_INFO_BAR_SUPPORT and its statusbar-only
> fallback go away; the info bar is now built unconditionally.
> 
> Signed-off-by: Matt Turner <mattst88@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-perf-gtk2-v4-0-97e92ee07214@gmail.com?part=1