Re: [PATCH 3/3] dtc: dt-check-style: Consistently pass same content as stripped line

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Passing `stripped` instead of `code` to `DtsLine` for continuation lines breaks code parsing when comments contain quotes, causing false positive style warnings.
--

commit b0e5f002675043b5c126935e8c52f79036f0359b
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

dtc: dt-check-style: Consistently pass same content as stripped line

This commit updates the dt-check-style script to pass the stripped string
instead of code to the DtsLine constructor for continuation lines. This is
intended to make the arguments consistent with other DtsLine constructor calls.

> diff --git a/scripts/dtc/dt-check-style b/scripts/dtc/dt-check-style
> index 36e5b5db5e14c..49ced18895583 100755
> --- a/scripts/dtc/dt-check-style
> +++ b/scripts/dtc/dt-check-style
> @@ -203,7 +203,7 @@ def classify_lines(text):
>              in_block_comment = True
>  
>          if not prev_complete:
> -            dl = DtsLine(i, raw, LineType.CONTINUATION, depth, indent_str, code)
> +            dl = DtsLine(i, raw, LineType.CONTINUATION, depth, indent_str, stripped)

[Severity: Medium]
Does passing stripped instead of code break parsing when comments contain
quotes?

By passing stripped (which still contains comments) instead of the properly
pre-parsed code, DtsLine.__init__ falls back to its regex-based
_strip_strings_and_comments() method which incorrectly consumes valid code
if a quote appears within a comment.

This can cause the dt-check-style script to generate false positive style
warnings on valid DTS files when a continuation line contains a comment with
an unescaped double quote (e.g., some_prop = "a", /* comment " */ "b";).

>              out.append(dl)
>              prev_complete = (code.endswith(';') or
>                               code.endswith('{') or

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906180437.166760-4-krzysztof.kozlowski@oss.qualcomm.com?part=3