Re: [PATCH v5 1/2] tools: port perf ui from GTK 2 to GTK 4

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] Missing explicit inclusions of POSIX libc headers (`<stdio.h>`, `<stdarg.h>`, `<string.h>`) in `hists.c` and `annotate.c`, violating musl compatibility guidelines.
--

commit add3ec3dbce9f1d3bd46b20c11244baa3a6dfeae
Author: Matt Turner <mattst88@gmail.com>

tools: port perf ui from GTK 2 to GTK 4

This commit ports the perf GTK UI to GTK 4, migrating deprecated constructs 
like GtkContainer and GdkScreen to their modern equivalents. It updates the
main and error-dialog loops to use explicit GMainLoops, defers exit signals, 
and removes conditional checks for the GTK info bar.

> diff --git a/tools/perf/ui/gtk/annotate.c b/tools/perf/ui/gtk/annotate.c
> index 8920e298420a8..b89389a3b92f1 100644
> --- a/tools/perf/ui/gtk/annotate.c
> +++ b/tools/perf/ui/gtk/annotate.c

[Severity: Medium]
This isn't a bug introduced by this patch, but since the commit message 
mentions adding explicit inclusions for musl compatibility, does this file 
also need <string.h> included directly?

Looking at perf_gtk__get_percent() in this file, it relies on strcpy():

perf_gtk__get_percent() {
    ...
    strcpy(buf, "");
    ...
}

Since musl strictly separates declarations, relying on implicit includes
can cause compilation failures for environments building against it.

[ ... ]

> diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
> index bae21f336ae6d..d8eec453dd094 100644
> --- a/tools/perf/ui/gtk/hists.c
> +++ b/tools/perf/ui/gtk/hists.c

[Severity: Medium]
This is a pre-existing issue, but similarly to the above, would it be 
appropriate to explicitly include <stdio.h> and <stdarg.h> here to ensure 
musl compatibility?

For example, perf_gtk__add_hierarchy_entries() uses snprintf():

perf_gtk__add_hierarchy_entries() {
    ...
    snprintf(buf, sizeof(buf), "no entry >= %.2f%%", min_pcnt);
    ...
}

Additionally, __percent_color_snprintf() relies on va_list:

static int __percent_color_snprintf(struct perf_hpp *hpp, const char *fmt, ...)

Adding the explicit POSIX libc headers would prevent undefined function 
errors on systems using musl instead of glibc.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-perf-gtk2-v5-0-e8747a65c240@gmail.com?part=1