Re: [RFC PATCH 1/6] mm/damon/api: introduce DAMOS_FILTER_TYPE_PROBE_HITS_WSUM

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between kernel-doc comment and the actual struct field name for range_max.
--

commit 7d0758e3c3054c52a080a43553753f124a5933b1
Author: SJ Park <sj@kernel.org>

mm/damon/api: introduce DAMOS_FILTER_TYPE_PROBE_HITS_WSUM

Update DAMON kernel API to introduce new DAMOS core filter type,
PROBE_HITS_WSUM. It adds two type-dependent union fields to damos_filter
for describing the filtering target weighted sum range.

> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 871d26adf6ae5..59d57131d8327 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
[ ... ]
> @@ -434,6 +436,8 @@ enum damos_filter_type {
>   *		&damon_ctx->adaptive_targets if @type is
>   *		DAMOS_FILTER_TYPE_TARGET.
>   * @sz_range:	Size range if @type is DAMOS_FILTER_TYPE_HUGEPAGE_SIZE.
> + * @range_min:	Minimum value of range arguments.
> + * @range_mx:	Maximum value of range arguments.

[Severity: Low]
This isn't a bug, but there appears to be a typo in the kernel-doc comment
compared to the actual struct field. Should this be @range_max instead of
@range_mx to match the struct field defined below?

>   *
>   * Before applying the &damos->action to a memory region, DAMOS checks if each
>   * byte of the region matches to this given condition and avoid applying the
> @@ -450,6 +454,10 @@ struct damos_filter {
>  		struct damon_addr_range addr_range;
>  		int target_idx;
>  		struct damon_size_range sz_range;
> +		struct {
> +			unsigned long range_min;
> +			unsigned long range_max;
> +		};
>  	};
>  /* private: */
>  	/* List head for siblings. */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906210513.106895-1-sj@kernel.org?part=1