Re: [PATCH v10 1/2] dt-bindings: mfd: x-powers: Add AC200

[sashiko-bot@kernel.org]

> The AC200 is an I2C-controlled mixed-signal companion IC containing
> audio, video, RTC and Fast Ethernet PHY functions.
> 
> Describe the parent device and its shared input clock together with the
> audio codec and TV encoder child nodes. Keep their analog supplies on the
> function consumers and describe the TV encoder display graph and optional
> bandgap calibration cell.
> 
> Add the shared interrupt-controller properties and interrupt numbers used
> by the TV encoder. The Ethernet PHY is represented by a PHY package on its
> MDIO bus, with a phandle back to this device for access to the package
> control registers, so it does not require an MFD child node.
> 
> Keep the INTB connection and TV encoder interrupt optional, including when
> the TV encoder is enabled. Cable detection status is readable over I2C
> without an interrupt. If a TV encoder interrupt is described, require the
> parent interrupt domain and its upstream connection. Include examples
> with and without INTB connected.
> 
> The input clock must run at 24 or 27 MHz when the Ethernet PHY is used,
> matching the rates encoded by its documented clock selector.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260906-submit-ac200-mfd-v10-0-f522e8dc2bd4@gmail.com?part=1