From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85353C79F89 for ; Mon, 7 Sep 2026 11:28:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B53FD10E4AB; Mon, 7 Sep 2026 11:28:31 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="AESFJRn2"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 55D5310E4AB for ; Mon, 7 Sep 2026 11:28:26 +0000 (UTC) Received: from [127.0.1.1] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id ED8CBC45; Mon, 7 Sep 2026 13:26:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1788780410; bh=nimBzwK8X0eTgWDSpsHRmSDTtL6PqLdjOLgBI2Bu8ns=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AESFJRn2WkP5omAnx1k8cmmMIdxrE3k3zVLzo8UNX6OliCgfsG/bD/6NUJawn84qB aTRvPFKL6T3s2UujU7Q3QeHYLSFgXyqMgZW4vBY2lYgvcJuZiNnbahezkAeDJ4RuHu Jm4EYNdg+TdJDtTU5EvaBuaX4qVC8TkBgRT6ntPw= From: Tomi Valkeinen Date: Mon, 07 Sep 2026 14:27:57 +0300 Subject: [PATCH v4 02/13] drm/bridge: tc358762: Improve SYSCTRL register defines MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260907-tc358762-fixes-v4-2-e3fc3ab5cd83@ideasonboard.com> References: <20260907-tc358762-fixes-v4-0-e3fc3ab5cd83@ideasonboard.com> In-Reply-To: <20260907-tc358762-fixes-v4-0-e3fc3ab5cd83@ideasonboard.com> To: Marek Vasut , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tomi Valkeinen X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1738; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=nimBzwK8X0eTgWDSpsHRmSDTtL6PqLdjOLgBI2Bu8ns=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBqnp/RrrdUdFYarVd4ED8bHoJcNUFhwkgk8U9WW rJ/Kha/m52JAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCap6f0QAKCRD6PaqMvJYe 9aE9EACYuVN8HDKfwEGdusNHy1rurP2Fsxq3/UMXfFYG3o0Ned/cXK3ZUkEgTaMlxqTEnMH72k0 buKgP8sm5/6ReELIbTMj5BpVR7bRFxaZzCX0yKZQCGLR5vQ+sXMSQvR3wXQzw6ufb5Y7QQce/Cq md72LIDF2mGl+KpiJ7ADYgA4nPrdp10DJNz+Mgvr2ulCEG6DGgKACm/qurcvn5Qf5k8R0Gk9xiw 2QSTQlcZ+Jz3ATSj/Uwt3DAmFRWcjhKD5z7SJQtTz9YYQ27OLccy7CTj/gGG7+5aBIr6J/b+23N kO8wRZQMqhbkC2xy9foA3Pznf/UgZselZLYIk15vP1liKjXRLnKweqju/8DbxaQMGeqUcgt/78b 2T2cpbGV+FaDElEe2LSMuiYwK4wapoLjyTxDZVZNLnPykFJbv4/ULY3QcBVphs+WBSjvmORs4eC 7eakC57JZkW86COwVUh5Jf5qpqNERx8hphHAtuXx0Q//D+qLmtkKaPokrC0h3etTDba8Cl7RDGj KWoyAExOutb2N1Je9qeEEUuMnPIeCWH0FZuxqcaqd66czGXvAlcpCN9rX3Q5R37MAV4WQcMaX/m +mCYHYJgcAii0kLukniLeBdCmf7ZsR/UwnBtTY+MWqOSO/+NmjyXDb/Px/TvFL5BOpH/CeIVuGl dxbVBMNdvnvYACg== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Define SYSCTRL fields. No functional changes. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358762.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c index dc20f253c7ad..5630cead7cd8 100644 --- a/drivers/gpu/drm/bridge/tc358762.c +++ b/drivers/gpu/drm/bridge/tc358762.c @@ -10,6 +10,7 @@ * Eric Anholt */ +#include #include #include #include @@ -63,6 +64,19 @@ /* System Controller Registers */ #define SYSCTRL 0x0464 +#define SYSCTRL_DPIDATA_IO_MASK GENMASK_U32(1, 0) +#define SYSCTRL_DPIDATA_IO_1MA 0 +#define SYSCTRL_DPIDATA_IO_2MA 1 +#define SYSCTRL_DPIDATA_IO_3MA 2 +#define SYSCTRL_DPIDATA_IO_4MA 3 +#define SYSCTRL_DPISTB_IO_MASK GENMASK_U32(3, 2) +#define SYSCTRL_DPISTB_IO_1MA 0 +#define SYSCTRL_DPISTB_IO_2MA 1 +#define SYSCTRL_DPISTB_IO_3MA 2 +#define SYSCTRL_DPISTB_IO_4MA 3 +#define SYSCTRL_PCLKDIV_MASK GENMASK_U32(11, 8) +#define SYSCTRL_PCLKDIV_DIV_2 2 +#define SYSCTRL_PCLKDIV_DIV_3 4 #define LPX_PERIOD 3 @@ -136,7 +150,11 @@ static int tc358762_init(struct tc358762 *ctx) tc358762_write(ctx, LCDCTRL, lcdctrl); - tc358762_write(ctx, SYSCTRL, 0x040f); + tc358762_write(ctx, SYSCTRL, + FIELD_PREP(SYSCTRL_DPIDATA_IO_MASK, SYSCTRL_DPIDATA_IO_4MA) | + FIELD_PREP(SYSCTRL_DPISTB_IO_MASK, SYSCTRL_DPISTB_IO_4MA) | + FIELD_PREP(SYSCTRL_PCLKDIV_MASK, SYSCTRL_PCLKDIV_DIV_3)); + msleep(100); tc358762_write(ctx, PPI_STARTPPI, PPI_STARTPPI_STARTPPI); -- 2.43.0