All of lore.kernel.org
 help / color / mirror / Atom feed
From: shechenglong <shechenglong@xfusion.com>
To: <sashiko-bot@kernel.org>
Cc: <dri-devel@lists.freedesktop.org>,
	<sashiko-reviews@lists.linux.dev>, <shechenglong@xfusion.com>,
	<chenjialong@xfusion.com>, <stone.xulei@xfusion.com>
Subject: Re: [PATCH] drm/client: fix restore of partially initialized client
Date: Mon, 7 Sep 2026 15:04:33 +0800	[thread overview]
Message-ID: <20260907070433.1412-1-shechenglong@xfusion.com> (raw)
In-Reply-To: <20260907041237.C7E301F00A3A@smtp.kernel.org>

> Could the error handling path be updated to ensure the buffer is properly
> destroyed when this occurs?

Thanks for pointing this out.

This appears to be a pre-existing issue and is not introduced by this
patch. The purpose of the current patch is limited to preventing the
restore callback from dereferencing a partially initialized fbdev
client.

The cleanup concern looks valid. I will inspect the buffer ownership and
error-unwind paths around register_framebuffer() failure. If additional
cleanup is required, I will handle it separately so that the restore fix
remains focused.

Thanks,
Chenglong She

  reply	other threads:[~2026-09-07  7:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07  3:51 [PATCH] drm/client: fix restore of partially initialized client shechenglong
2026-09-07  4:12 ` sashiko-bot
2026-09-07  7:04   ` shechenglong [this message]
2026-09-17 14:33 ` [PATCH RESEND] " shechenglong
2026-09-17 14:46 ` [PATCH] " Thomas Zimmermann
2026-09-17 15:47 ` [PATCH v2] " shechenglong
2026-09-17 16:06   ` sashiko-bot
2026-09-17 17:00     ` Thomas Zimmermann
2026-09-17 17:01   ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907070433.1412-1-shechenglong@xfusion.com \
    --to=shechenglong@xfusion.com \
    --cc=chenjialong@xfusion.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=stone.xulei@xfusion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.