From: Christoph Hellwig <hch@lst.de>
To: Zorro Lang <zlang@kernel.org>
Cc: fstests@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Kanchan Joshi <joshi.k@samsung.com>,
Anuj Gupta <anuj20.g@samsung.com>,
John Garry <john.g.garry@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-scsi@vger.kernel.org
Subject: [PATCH 1/6] common/scsi_debug: don't slow down I/O
Date: Mon, 7 Sep 2026 10:58:11 +0300 [thread overview]
Message-ID: <20260907075822.749818-2-hch@lst.de> (raw)
In-Reply-To: <20260907075822.749818-1-hch@lst.de>
scsi_debug by defaults delays I/O and doesn't support multi-page I/O.
Flipping these defaults speed up each test using scsi_debug by more than
an order of magnitute on my test systems.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
---
common/scsi_debug | 16 +++++++++++++---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/common/scsi_debug b/common/scsi_debug
index c3fe7be623fa..af51905dc4ba 100644
--- a/common/scsi_debug
+++ b/common/scsi_debug
@@ -59,9 +59,19 @@ _get_scsi_debug_dev()
let physical=physical/2
let phys_exp=phys_exp+1
done
- opts="sector_size=$logical physblk_exp=$phys_exp lowest_aligned=$unaligned dev_size_mb=$size $@"
- echo "scsi_debug options $opts" >> $seqres.full
- modprobe scsi_debug $opts
+
+ local opts=(
+ "sector_size=$logical"
+ "physblk_exp=$phys_exp"
+ "lowest_aligned=$unaligned"
+ "dev_size_mb=$size"
+ "delay=0"
+ "clustering=1"
+ )
+ opts+=("$@")
+
+ echo "scsi_debug options ${opts[*]}" >> $seqres.full
+ modprobe scsi_debug "${opts[@]}"
[ $? -eq 0 ] || _fail "scsi_debug modprobe failed"
$UDEV_SETTLE_PROG
device=`grep -wl scsi_debug /sys/block/sd*/device/model | awk -F / '{print $4}'`
--
2.53.0
next prev parent reply other threads:[~2026-09-07 7:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 7:58 add tests for file system on devices using protection information v4 Christoph Hellwig
2026-09-07 7:58 ` Christoph Hellwig [this message]
2026-09-07 7:58 ` [PATCH 2/6] common: factor out a _bdev_disk_name helper Christoph Hellwig
2026-09-07 7:58 ` [PATCH 3/6] common: add a _sysfs_block_integrity_path helper Christoph Hellwig
2026-09-08 14:32 ` Kanchan Joshi
2026-09-07 7:58 ` [PATCH 4/6] add a "pi" group Christoph Hellwig
2026-09-08 14:33 ` Kanchan Joshi
2026-09-07 7:58 ` [PATCH 5/6] generic: test I/O on devices with T10 protection information Christoph Hellwig
2026-09-08 14:33 ` Kanchan Joshi
2026-09-07 7:58 ` [PATCH 6/6] generic: test corruption detection using " Christoph Hellwig
2026-09-08 14:36 ` Kanchan Joshi
-- strict thread matches above, loose matches on Subject: below --
2026-09-11 7:08 add tests for file system on devices using protection information v5 Christoph Hellwig
2026-09-11 7:08 ` [PATCH 1/6] common/scsi_debug: don't slow down I/O Christoph Hellwig
2026-09-13 12:23 ` Zorro Lang
2026-08-31 6:45 add tests for file system on devices using protection information v3 Christoph Hellwig
2026-08-31 6:45 ` [PATCH 1/6] common/scsi_debug: don't slow down I/O Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907075822.749818-2-hch@lst.de \
--to=hch@lst.de \
--cc=anuj20.g@samsung.com \
--cc=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=john.g.garry@oracle.com \
--cc=joshi.k@samsung.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=zlang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.