From: Christoph Hellwig <hch@lst.de>
To: aalbersh@kernel.org
Cc: linux-xfs@vger.kernel.org
Subject: [PATCH] xfs_io: cleanup headers
Date: Mon, 7 Sep 2026 11:01:00 +0300 [thread overview]
Message-ID: <20260907080100.749981-1-hch@lst.de> (raw)
Drop extra externs and deep tab indentation of the function and
variable names.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
io/init.h | 10 ++--
io/io.h | 164 +++++++++++++++++++++++++++---------------------------
2 files changed, 87 insertions(+), 87 deletions(-)
diff --git a/io/init.h b/io/init.h
index d4d1968cc1e1..97a93761d64f 100644
--- a/io/init.h
+++ b/io/init.h
@@ -8,10 +8,10 @@
#define CMD_NOMAP_OK (1<<1) /* command doesn't need a mapped region */
#define CMD_FOREIGN_OK CMD_FLAG_FOREIGN_OK
-extern char *progname;
-extern int exitcode;
-extern int expert;
-extern size_t pagesize;
+extern char *progname;
+extern int exitcode;
+extern int expert;
+extern size_t pagesize;
extern struct timeval stopwatch;
-extern void init_cvtnum(size_t *blocksize, size_t *sectsize);
+void init_cvtnum(size_t *blocksize, size_t *sectsize);
diff --git a/io/io.h b/io/io.h
index 5f1f278d14a0..50e01b3cd229 100644
--- a/io/io.h
+++ b/io/io.h
@@ -45,11 +45,13 @@ typedef struct fileio {
struct fs_path fs_path; /* XFS path information */
} fileio_t;
-extern fileio_t *filetable; /* open file table */
-extern int filecount; /* number of open files */
-extern fileio_t *file; /* active file in file table */
-extern int filelist_f(void);
-extern int stat_f(int argc, char **argv);
+extern fileio_t *filetable; /* open file table */
+extern int filecount; /* number of open files */
+extern fileio_t *file; /* active file in file table */
+
+int filelist_f(void);
+int stat_f(int argc, char **argv);
+
/*
* Memory mapped file regions
*/
@@ -62,111 +64,109 @@ typedef struct mmap_region {
char *name; /* name of backing file */
} mmap_region_t;
-extern mmap_region_t *maptable; /* mmap'd region array */
-extern int mapcount; /* #entries in the mapping table */
-extern mmap_region_t *mapping; /* active mapping table entry */
-extern int maplist_f(void);
-extern void *check_mapping_range(mmap_region_t *, off_t, size_t, int);
+extern mmap_region_t *maptable; /* mmap'd region array */
+extern int mapcount; /* #entries in the mapping table */
+extern mmap_region_t *mapping; /* active mapping table entry */
+
+int maplist_f(void);
+void *check_mapping_range(mmap_region_t *, off_t, size_t, int);
/*
* Various xfs_io helper routines/globals
*/
-extern off_t filesize(void);
-extern int openfile(char *, struct xfs_fsop_geom *, int, mode_t,
- struct fs_path *);
-extern int addfile(char *, int , struct xfs_fsop_geom *, int,
- struct fs_path *);
-extern int closefile(void);
-extern void print_xflags(uint, int, int, const char *, int, int);
-
-extern unsigned int recurse_all;
-extern unsigned int recurse_dir;
-
-extern void *io_buffer;
-extern size_t io_buffersize;
-extern int vectors;
-extern struct iovec *iov;
-extern int alloc_buffer(size_t, int, unsigned int);
-extern int read_buffer(int, off_t, long long, long long *,
- int, int);
-extern void dump_buffer(off_t, ssize_t);
-
-extern void attr_init(void);
-extern void bmap_init(void);
-extern void encrypt_init(void);
-extern void file_init(void);
-extern void flink_init(void);
-extern void freeze_init(void);
-extern void fsuuid_init(void);
-extern void fsync_init(void);
-extern void getrusage_init(void);
-extern void help_init(void);
-extern void imap_init(void);
-extern void inject_init(void);
-extern void label_init(void);
-extern void mmap_init(void);
-extern void open_init(void);
-extern void parent_init(void);
-extern void pread_init(void);
-extern void prealloc_init(void);
-extern void pwrite_init(void);
-extern void quit_init(void);
-extern void resblks_init(void);
-extern void seek_init(void);
-extern void shutdown_init(void);
-extern void stat_init(void);
-extern void swapext_init(void);
-extern void sync_init(void);
-extern void truncate_init(void);
-extern void utimes_init(void);
-extern void fadvise_init(void);
-extern void sendfile_init(void);
-extern void madvise_init(void);
-extern void mincore_init(void);
-extern void fiemap_init(void);
+off_t filesize(void);
+int openfile(char *, struct xfs_fsop_geom *, int, mode_t, struct fs_path *);
+int addfile(char *, int , struct xfs_fsop_geom *, int, struct fs_path *);
+int closefile(void);
+void print_xflags(uint, int, int, const char *, int, int);
+
+extern unsigned int recurse_all;
+extern unsigned int recurse_dir;
+
+extern void *io_buffer;
+extern size_t io_buffersize;
+extern int vectors;
+extern struct iovec *iov;
+
+int alloc_buffer(size_t, int, unsigned int);
+int read_buffer(int, off_t, long long, long long *, int, int);
+void dump_buffer(off_t, ssize_t);
+void attr_init(void);
+void bmap_init(void);
+void encrypt_init(void);
+void file_init(void);
+void flink_init(void);
+void freeze_init(void);
+void fsuuid_init(void);
+void fsync_init(void);
+void getrusage_init(void);
+void help_init(void);
+void imap_init(void);
+void inject_init(void);
+void label_init(void);
+void mmap_init(void);
+void open_init(void);
+void parent_init(void);
+void pread_init(void);
+void prealloc_init(void);
+void pwrite_init(void);
+void quit_init(void);
+void resblks_init(void);
+void seek_init(void);
+void shutdown_init(void);
+void stat_init(void);
+void swapext_init(void);
+void sync_init(void);
+void truncate_init(void);
+void utimes_init(void);
+void fadvise_init(void);
+void sendfile_init(void);
+void madvise_init(void);
+void mincore_init(void);
+void fiemap_init(void);
#ifdef HAVE_COPY_FILE_RANGE
-extern void copy_range_init(void);
+void copy_range_init(void);
#else
#define copy_range_init() do { } while (0)
#endif
#ifdef HAVE_CACHESTAT
-extern void cachestat_init(void);
+void cachestat_init(void);
#else
#define cachestat_init() do { } while (0)
#endif
-extern void sync_range_init(void);
-extern void readdir_init(void);
-extern void reflink_init(void);
-extern void cowextsize_init(void);
+void sync_range_init(void);
+void readdir_init(void);
+void reflink_init(void);
+void cowextsize_init(void);
#ifdef HAVE_GETFSMAP
-extern void fsmap_init(void);
+void fsmap_init(void);
#else
# define fsmap_init() do { } while (0)
#endif
#ifdef HAVE_DEVMAPPER
-extern void log_writes_init(void);
+void log_writes_init(void);
#else
#define log_writes_init() do { } while (0)
#endif
-extern void scrub_init(void);
-extern void repair_init(void);
-extern void crc32cselftest_init(void);
-extern void bulkstat_init(void);
-void exchangerange_init(void);
-void fsprops_init(void);
-void aginfo_init(void);
-void healthmon_init(void);
-void verifymedia_init(void);
+void scrub_init(void);
+void repair_init(void);
+void crc32cselftest_init(void);
+void bulkstat_init(void);
+void exchangerange_init(void);
+void fsprops_init(void);
+void aginfo_init(void);
+void healthmon_init(void);
+void verifymedia_init(void);
#ifdef HAVE_LISTMOUNT
-void listmount_init(void);
+void listmount_init(void);
#else
-# define listmount_init() do { } while (0)
+# define listmount_init() do { } while (0)
#endif
--
2.53.0
next reply other threads:[~2026-09-07 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 8:01 Christoph Hellwig [this message]
2026-09-07 9:12 ` [PATCH] xfs_io: cleanup headers Andrey Albershteyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907080100.749981-1-hch@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.