Re: [PATCH v5 1/4] dt-bindings: usb: add Altera Agilex5 DWC3 controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema incorrectly uses `additionalProperties: false` instead of `unevaluatedProperties: false`, which negates inherited schemas and forces redundant property declarations.
--

commit 9d62a972209f1de97f540bff2202c5f7fd9c1a48
Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>

dt-bindings: usb: add Altera Agilex5 DWC3 controller

Add a binding for the Altera Agilex5 SoC integration of the Synopsys DWC3
USB controller, covering clocks, resets, PHYs, and optional IOMMU support.

> diff --git a/Documentation/devicetree/bindings/usb/altr,agilex5-dwc3.yaml b/Documentation/devicetree/bindings/usb/altr,agilex5-dwc3.yaml
> new file mode 100644
> index 0000000000000..9970d7c9d6fae
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/altr,agilex5-dwc3.yaml
[ ... ]
> +  reset-names:
> +    items:
> +      - const: core
> +      - const: ecc
> +
> +  dr_mode: true
> +
> +  maximum-speed: true
> +
> +  snps,dis_u2_susphy_quirk: true
> +
> +  snps,dis_u3_susphy_quirk: true

[Severity: Medium]
Are these property declarations necessary?

These dummy redeclarations appear to be a workaround for the
additionalProperties restriction below. Once unevaluatedProperties: false is
used instead, these can be safely removed as they will be properly inherited
from the common schema.

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - interrupts
> +  - phys
> +  - phy-names
> +  - resets
> +  - reset-names
> +
> +additionalProperties: false

[Severity: Medium]
Does this incorrectly reject standard properties inherited from
snps,dwc3-common.yaml?

Using additionalProperties: false instead of unevaluatedProperties: false
strictly restricts properties to only those defined in this file. This breaks
schema inheritance, meaning any standard DWC3 properties not explicitly
redefined here will cause dt_binding_check to fail.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1788757821.git.adrian.ho.yin.ng@altera.com?part=1