All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ayush Mukkanwar <ayushmukkanwar@gmail.com>
Cc: error27@gmail.com, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	skhan@linuxfoundation.org, sashiko-bot@kernel.org
Subject: Re: [PATCH 1/2] staging: octeon: fix use-after-free in tasklet teardown
Date: Mon, 7 Sep 2026 18:29:33 +0200	[thread overview]
Message-ID: <2026090710-disposal-tameness-3d85@gregkh> (raw)
In-Reply-To: <20260905153530.36693-1-ayushmukkanwar@gmail.com>

On Sat, Sep 05, 2026 at 09:05:29PM +0530, Ayush Mukkanwar wrote:
> cvm_oct_tx_shutdown() kills the tx cleanup tasklet while
> the net devices are still registered. This could lead
> to use-after-free when a tasklet is scheduled after the
> tasklet_kill() is called which might run after the net
> devices are freed.
> Fix it by unregistering the net devices before the tasklet
> is killed.
> 
> Fixes: 4898c560103f ("Staging: Octeon:  Free transmit SKBs in a timely manner")
> Reported-by: Sashiko <sashiko-bot@kernel.org>
> Closes: https://sashiko.dev/#/message/20260615172734.42038-1-ayushmukkanwar%40gmail.com
> Signed-off-by: Ayush Mukkanwar <ayushmukkanwar@gmail.com>
> ---
> Note: This patch has only been compile tested. No runtime testing was
> performed as I do not have access to Octeon hardware.

Please wait until you have the hardware, as the sashiko review comments
say there are still issues with this patch series :(

thanks,

greg k-h

      parent reply	other threads:[~2026-09-07 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-05 15:35 [PATCH 1/2] staging: octeon: fix use-after-free in tasklet teardown Ayush Mukkanwar
2026-09-05 15:35 ` [PATCH 2/2] staging: octeon: fix out-of-bounds reads in tx path Ayush Mukkanwar
2026-09-07 16:29 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026090710-disposal-tameness-3d85@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=ayushmukkanwar@gmail.com \
    --cc=error27@gmail.com \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sashiko-bot@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.