Re: [PATCH 1/2] dt-bindings: iio: adc: ad4080: add AD4885 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema fails to enforce the presence of the `io-backends` property, despite the commit message explicitly stating it is required.
--

commit 9fc058b2c408d54ffde599d33ff5e645acdf0ad1
Author: Antoniu Miclaus <antoniu.miclaus@analog.com>

dt-bindings: iio: adc: ad4080: add AD4885 support

Add AD4885 compatible string to the AD4080 devicetree binding. The AD4885
is a dual-channel variant that requires two SPI chip selects and two
io-backends for its independent ADC channels.

> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> index db8467b98e67d..07ac4e07f415a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4080.yaml

[ ... ]

> @@ -105,6 +106,7 @@ allOf:
>                - adi,ad4880
>                - adi,ad4883
>                - adi,ad4884
> +              - adi,ad4885
>      then:
>        properties:
>          reg:

[Severity: Medium]
The commit message states that the AD4885 "requires two SPI chip selects and
two io-backends for its independent ADC channels."

While this conditional block applies constraints to the newly added adi,ad4885
variant, it does not enforce the presence of the io-backends property:

    then:
      properties:
        reg:
          minItems: 2
        io-backends:
          minItems: 2

Should a required directive be added to this block to enforce the presence of
the io-backends property as claimed in the commit message?

    then:
      properties:
        ...
      required:
        - io-backends

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907101944.9748-1-antoniu.miclaus@analog.com?part=1