All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Subject: [PATCH v2 1/2] net/i40e: fix MAC address removal
Date: Mon,  7 Sep 2026 13:17:23 +0200	[thread overview]
Message-ID: <20260907111724.3043887-1-david.marchand@redhat.com> (raw)
In-Reply-To: <20260904121651.2254684-1-david.marchand@redhat.com>

MAC addresses removal was tied with VMDq pools even when not used.
So if VMDq is not enabled, no address would be ever removed.

Fixes: 9de506a6c781 ("ethdev: skip VMDq pools unless configured")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
I could not test the change as my setups are KO atm.

Probably worth squashing in 9de506a6c781 before pulling to main

Changes since v1:
- fixed compilation,

---
 drivers/net/intel/i40e/i40e_ethdev.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c
index b6b2d291ee..3c01354c39 100644
--- a/drivers/net/intel/i40e/i40e_ethdev.c
+++ b/drivers/net/intel/i40e/i40e_ethdev.c
@@ -4509,11 +4509,16 @@ i40e_macaddr_remove(struct rte_eth_dev *dev, uint32_t index)
 	struct rte_ether_addr *macaddr;
 	int ret;
 	uint32_t i;
+	bool vmdq;
 	uint64_t pool_sel;
 
 	macaddr = &(data->mac_addrs[index]);
 
-	pool_sel = dev->data->mac_pool_sel[index];
+	vmdq = (dev->data->dev_conf.rxmode.mq_mode & RTE_ETH_MQ_RX_VMDQ_FLAG) != 0;
+	if (!vmdq)
+		pool_sel = 1;
+	else
+		pool_sel = dev->data->mac_pool_sel[index];
 
 	for (i = 0; i < sizeof(pool_sel) * CHAR_BIT; i++) {
 		if (pool_sel & RTE_BIT64(i)) {
-- 
2.54.0


  parent reply	other threads:[~2026-09-07 11:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-04 12:16 [PATCH 1/2] net/i40e: fix MAC address removal David Marchand
2026-09-04 12:16 ` [PATCH 2/2] net/bnxt: " David Marchand
2026-09-04 13:08 ` [PATCH 1/2] net/i40e: " David Marchand
2026-09-07 11:17 ` David Marchand [this message]
2026-09-07 11:17   ` [PATCH v2 2/2] net/bnxt: " David Marchand
2026-09-07 17:17     ` Stephen Hemminger
2026-09-07 12:57   ` [PATCH v2 1/2] net/i40e: " Bruce Richardson
2026-09-07 13:21     ` David Marchand
2026-09-07 13:40       ` Bruce Richardson
2026-09-08  7:18 ` [PATCH v3 " David Marchand
2026-09-08  7:18   ` [PATCH v3 2/2] net/bnxt: " David Marchand
2026-09-08 14:23     ` Stephen Hemminger
2026-09-08  7:38   ` [PATCH v3 1/2] net/i40e: " Bruce Richardson
2026-09-08 14:23   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907111724.3043887-1-david.marchand@redhat.com \
    --to=david.marchand@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.