Re: [PATCH] hwmon: (yogafan) Add support for new Lenovo models

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The DMI quirk entry for 'Yoga 14cACN 2021' is completely redundant and duplicates the fallback generic 'Lenovo Yoga' configuration.
--

commit 11ad066ce5492c24b9a778e999582125b519d21a
Author: Sergio Melas <sergiomelas@gmail.com>

hwmon: (yogafan) Add support for new Lenovo models
    
Add DMI quirk entries and map correct ACPI paths and configurations for
additional Lenovo laptop models: Yoga 14cACN 2021, IdeaPad 3 15ALC6 Ub
and Yoga 740-15IML, leveraging DMI product family matching.

> diff --git a/drivers/hwmon/yogafan.c b/drivers/hwmon/yogafan.c
> index 48fa5148d9e2c..2f86a8f6e0aeb 100644
> --- a/drivers/hwmon/yogafan.c
> +++ b/drivers/hwmon/yogafan.c

[ ... ]

> @@ -189,6 +194,30 @@ static const struct hwmon_chip_info yoga_fan_chip_info = {
>  };
>  
>  static const struct dmi_system_id yogafan_quirks[] = {

[ ... ]

> +	{
> +		.ident = "Yoga 14cACN 2021",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "Yoga 14cACN 2021"),
> +		},
> +		.driver_data = (void *)&yoga_8bit_fans_cfg,
> +	},

[Severity: Low]
Is this specific DMI entry necessary?

Since DMI_MATCH performs a substring match, it appears any system with a
product family containing "Yoga 14cACN 2021" would already match the
generic "Yoga" fallback entry located later in this same array.

Because both entries map to the exact same yoga_8bit_fans_cfg driver data,
does this addition provide any functional benefit, or does it just
duplicate the existing fallback behavior?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907112929.1531690-1-sergiomelas@gmail.com?part=1