Re: [PATCH v5 01/10] ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The AIF child node uses a directional DAI ID as its 'reg' but mandates bidirectional configuration properties, creating a structural conflict.
--

commit 1e68cced9250cf9fdfbb8cdc27ee8ec47ada4a87
Author: Harendra Gautam <harendra.gautam@oss.qualcomm.com>

ASoC: dt-bindings: qcom,shikra-qaif-cpu: Add binding

Add the Devicetree binding for the Qualcomm Audio Interface (QAIF) CPU DAI
controller used on the Shikra audio platform, together with a dt-bindings
header for QAIF DAI and AIF interface IDs.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/qcom,shikra-qaif-cpu.yaml

[ ... ]

> +    properties:
> +      reg:
> +        maxItems: 1
> +        description:
> +          DAI ID of the AIF interface (QAIF_MI2S_AIF* or QAIF_TDM_AIF*).

[ ... ]

> +      qcom,qaif-aif-lane-map:
> +        $ref: /schemas/types.yaml#/definitions/uint32-array
> +        description:
> +          Per-lane direction map, one entry per lane starting from lane 0.
> +          Use 0 for TX (output/speaker) and 1 for RX (input/mic).

[ ... ]

> +    if:
> +      properties:
> +        dai-format:
> +          enum: [dsp_a, dsp_b]
> +    then:
> +      required:
> +        - dai-tdm-slot-width
> +        - dai-tdm-slot-num
> +        - dai-tdm-slot-rx-mask
> +        - dai-tdm-slot-tx-mask

[Severity: Medium]
Does this binding structure create a conflict for bidirectional interfaces?

Since the reg property requires a strictly directional DAI ID (like
AIF_TDM_RX_2), but the schema configures a bidirectional lane map and mandates
both dai-tdm-slot-rx-mask and dai-tdm-slot-tx-mask for DSP formats, this
appears to force both directions into a single node.

Looking at the driver in sound/soc/qcom/qaif-cpu.c, the function
of_qaif_parse_aif_intf_cfg() also prevents multiple nodes for the same physical
interface:

		if (configured_intf_mask & BIT(intf_idx)) {
			dev_err(dev, "Duplicate reg %d for interface %pOFn\n",
				dai_id, intf_np);
			of_node_put(intf_np);
			return -EINVAL;
		}

Does this force a bidirectional node to arbitrarily choose either the RX or
TX DAI ID for its reg property, preventing an accurate description of the
hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-b4-qaif-shikra-audio-v5-0-6d8ad9ba5c9f@oss.qualcomm.com?part=1