From: Artem Lytkin <iprintercanon@gmail.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux.dev,
Ido Schimmel <idosch@nvidia.com>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: bridge: bound the port VLAN lists in the IFLA_AF_SPEC nest
Date: Mon, 7 Sep 2026 16:35:04 +0300 [thread overview]
Message-ID: <20260907133505.5291-1-iprintercanon@gmail.com> (raw)
In-Reply-To: <ba2dcdb6-923d-4fc1-9c92-7a77c0b61a09@blackwall.org>
On Mon, Sep 07, 2026 at 11:47:24AM +0300, Nikolay Aleksandrov wrote:
> I prefer a more explicit path - return error for both (RTM_GETLINK and notifications)
> you'll have to plumb down extack but then user-space will know there are too many objects or lost
> RTNL_LINK notifications and it should resync (e.g. use RTM_GETVLAN to dump the vlans if needed).
OK, v2 will do that: br_fill_ifinfo() fails with -E2BIG once the nest
would pass 65535, kept distinct from -EMSGSIZE so the WARN_ON in
br_info_notify() still means what it means today and the error goes to
rtnl_set_sk_err(). For the dump, rtnl_bridge_getlink() can turn -E2BIG
into the extack message itself, which keeps ndo_bridge_getlink() as it
is; or do you want extack plumbed through the ndo? The size clamp and
the doc text go away.
Artem
next prev parent reply other threads:[~2026-09-07 13:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 22:42 [PATCH net-next] net: bridge: bound the port VLAN lists in the IFLA_AF_SPEC nest Artem Lytkin
2026-09-07 8:47 ` Nikolay Aleksandrov
2026-09-07 13:35 ` Artem Lytkin [this message]
2026-09-07 13:46 ` Nikolay Aleksandrov
2026-09-07 13:50 ` Nikolay Aleksandrov
2026-09-10 6:44 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907133505.5291-1-iprintercanon@gmail.com \
--to=iprintercanon@gmail.com \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.