From: Greg KH <gregkh@linuxfoundation.org>
To: Hank Yang <s950343@gmail.com>
Cc: marvin24@gmx.de, ac100@lists.launchpad.net,
linux-tegra@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: nvec: fix race between power-off callback and driver removal
Date: Mon, 7 Sep 2026 16:24:35 +0200 [thread overview]
Message-ID: <2026090714-trade-dealt-54b2@gregkh> (raw)
In-Reply-To: <20260906131529.11422-1-s950343@gmail.com>
On Sun, Sep 06, 2026 at 09:15:29PM +0800, Hank Yang wrote:
> tegra_nvec_remove() checks pm_power_off against nvec_power_off and
> then clears it in two separate steps:
>
> if (pm_power_off == nvec_power_off)
> pm_power_off = NULL;
>
> If a shutdown is triggered between the check and the clear, the
> system's power-off path can call nvec_power_off() while
> tegra_nvec_remove() is concurrently tearing down the device (freeing
> resources via mfd_remove_devices(), cancel_work_sync(), etc.),
> leading to a use-after-free on nvec_power_handle.
>
> Use cmpxchg() to make the check-and-clear atomic, closing this race
> window.
>
> Compile-tested (ARM, tegra_defconfig) only; I don't have access to
> Tegra Paz00 hardware to test this at runtime.
>
> Assisted-by: Claude:claude-sonnet-5
Please read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
sorry,
greg k-h
prev parent reply other threads:[~2026-09-07 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-06 13:15 [PATCH] staging: nvec: fix race between power-off callback and driver removal Hank Yang
2026-09-07 14:24 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026090714-trade-dealt-54b2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ac100@lists.launchpad.net \
--cc=linux-staging@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=s950343@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.