From: Jakub Kicinski <kuba@kernel.org>
To: Ratheesh Kannoth <rkannoth@marvell.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <pabeni@redhat.com>,
<sgoutham@marvell.com>, "Hariprasad Kelam" <hkelam@marvell.com>
Subject: Re: [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings
Date: Mon, 7 Sep 2026 14:40:38 -0700 [thread overview]
Message-ID: <20260907144038.0937d6ff@kernel.org> (raw)
In-Reply-To: <20260907042827.4077114-1-rkannoth@marvell.com>
On Mon, 7 Sep 2026 09:58:27 +0530 Ratheesh Kannoth wrote:
> otx2_get_link_ksettings() already fills speed, duplex, autoneg, link
> modes and FEC from CGX firmware data, but leaves cmd->base.port unset.
> As a result, ethtool does not show the physical connector type even
> though the firmware provides it in fwdata.port.
>
> Populate cmd->base.port from rsp->fwdata.port so users can see values
> such as PORT_TP or PORT_AUI via ethtool.
I said:
drivers should not blindly pass values between uAPI and the FW.
That means you have to add some explicit validation/translation
for each value even if they are numerically identical.
next prev parent reply other threads:[~2026-09-07 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 4:28 [PATCH v2 net-next] octeontx2-pf: report port connector type in ethtool link ksettings Ratheesh Kannoth
2026-09-07 7:23 ` Leon Romanovsky
2026-09-07 11:01 ` Ratheesh Kannoth
2026-09-07 11:35 ` Leon Romanovsky
2026-09-07 21:40 ` Jakub Kicinski [this message]
2026-09-08 2:31 ` Ratheesh Kannoth
2026-09-08 20:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907144038.0937d6ff@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rkannoth@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.