Re: [PATCH v8 6/9] iio: accel: mma8452: Add comment block for struct mma8452_data

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added kernel-doc block for `struct mma8452_data` documents non-existent fields (`@vdd_reg` and `@vddio_reg`) and omits the existing field `regs`, leading to kernel-doc validation warnings.
--

commit 9d34500f2316c8f0c0c1541db98718ec0f302931
Author: Esben Haabendal <esben@geanix.com>

iio: accel: mma8452: Add comment block for struct mma8452_data
    
The struct mma8452_data is central for this driver, and it makes sense to
have a description of the fields in it to make it easier to work with the
driver.

> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index c6af68d2a297a..2c1b97b77bc19 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -104,6 +104,22 @@
>  
>  #define MMA8452_AUTO_SUSPEND_DELAY_MS		2000
>  
> +/**
> + * struct mma8452_data - IIO device private data structure
> + * @client:			the I2C client object
> + * @lock:			mutex for synchronziation of register
> + *				read-modify-write and holding chip in STANDBY
> + *				mode while writing to registers
> + * @orientation:		mounting matrix, flipped axis etc
> + * @chip_info:			chip specific data
> + * @vdd_reg:			reference to VDD regulator
> + * @vddio_reg:			reference to VDDIO regulator

[Severity: Low]
Does this kernel-doc block accurately reflect the struct definition?

The newly added documentation lists @vdd_reg and @vddio_reg, but these
fields do not actually exist in struct mma8452_data.

This mismatch will trigger kernel-doc validation warnings when building
with W=1 or running kernel-doc tooling. Note that while a later commit
in this series adds the missing @open_drain field, this @vdd_reg and
@vddio_reg mismatch appears to remain unresolved.

> + * @buffer:			triggered buffer
> + * @sleep_val:			time in ms to sleep while waiting for drdy
> + * @ctrl_reg1:			CTRL_REG1 register shadow value
> + * @data_cfg:			DATA_CFG register shadow value
> + * @open_drain:			true for irq pin in open-drain mode
> + */
>  struct mma8452_data {
>  	struct i2c_client *client;
>  	struct mutex lock;

[Severity: Low]
Is an existing field missing from this documentation block?

The actual struct mma8452_data contains the following field which is
completely omitted from the newly added kernel-doc:

	struct regulator_bulk_data regs[2];

Like the non-existent fields above, omitting the documentation for the
existing regs field will result in kernel-doc validation warnings.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-mma8452-open-drain-v8-0-c17407e22118@geanix.com?part=6