From: linuxtestproject.agent@gmail.com
To: Michael Menasherov <mmenashe@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] read_all: Fix buffer too small for long paths
Date: Mon, 7 Sep 2026 14:58:29 +0000 [thread overview]
Message-ID: <20260907145829.9000-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260907120308.32898-1-mmenashe@redhat.com>
Hi Michael,
On Sep 7, 2026, Michael Menasherov wrote:
> read_all: Fix buffer too small for long paths
> +#define BUFFER_SIZE PATH_MAX
With the existing `if (++j >= BUFFER_SIZE - 1)` check, this still rejects a
valid PATH_MAX - 1-character pathname and reports TBROK before writing its
terminating NUL. A 4095-byte pathname reproduces this on PATH_MAX=4096; change
the queue_pop() bound so PATH_MAX - 1 characters fit.
Verdict - Needs revision
---
Note:
The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.
Regards,
LTP AI Reviewer
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-09-07 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 12:03 [LTP] [PATCH v2] read_all: Fix buffer too small for long paths Michael Menasherov via ltp
2026-09-07 14:58 ` linuxtestproject.agent [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-08 9:22 [LTP] [PATCH v3] " Michael Menasherov via ltp
2026-09-08 10:42 ` [LTP] " linuxtestproject.agent
2026-09-06 13:56 [LTP] [PATCH] " Michael Menasherov via ltp
2026-09-06 16:02 ` [LTP] " linuxtestproject.agent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907145829.9000-1-linuxtestproject.agent@gmail.com \
--to=linuxtestproject.agent@gmail.com \
--cc=ltp@lists.linux.it \
--cc=mmenashe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.