All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mickaël Salaün" <mic@digikod.net>
To: "Günther Noack" <gnoack@google.com>
Cc: "Mickaël Salaün" <mic@digikod.net>,
	linux-security-module@vger.kernel.org
Subject: [PATCH v1 2/2] selftests/landlock: Fix disconnected variant formatting
Date: Mon,  7 Sep 2026 18:07:07 +0200	[thread overview]
Message-ID: <20260907160710.126525-2-mic@digikod.net> (raw)
In-Reply-To: <20260907160710.126525-1-mic@digikod.net>

The s3d1_s4d1_disconnected_rename_even variant is missing the formatting
guard used by its neighbors.  This leaves its opening brace attached to
the FIXTURE_VARIANT_ADD() invocation and its clang-format enable marker
unmatched.

Restore the per-variant guard.  End it after the macro header so the
initializer remains managed by clang-format.

Cc: Günther Noack <gnoack@google.com>
Signed-off-by: Mickaël Salaün <mic@digikod.net>
---
 tools/testing/selftests/landlock/fs_test.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c
index 18dbdb99aeba..d0be84e572f5 100644
--- a/tools/testing/selftests/landlock/fs_test.c
+++ b/tools/testing/selftests/landlock/fs_test.c
@@ -5958,8 +5958,9 @@ FIXTURE_VARIANT_ADD(layout4_disconnected_leafs, s3d1_s4d1_new_parent_create) {
 	.expected_exchange_result = EXDEV,
 };
 
+/* clang-format off */
 FIXTURE_VARIANT_ADD(layout4_disconnected_leafs,
-		    s3d1_s4d1_disconnected_rename_even){
+		    s3d1_s4d1_disconnected_rename_even) {
 	/* clang-format on */
 	.allowed_s3d1 = LANDLOCK_ACCESS_FS_REFER | LANDLOCK_ACCESS_FS_MAKE_REG,
 	.allowed_s4d1 = LANDLOCK_ACCESS_FS_REFER | LANDLOCK_ACCESS_FS_MAKE_REG,
-- 
2.55.0


  reply	other threads:[~2026-09-07 16:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-07 16:07 [PATCH v1 1/2] selftests/landlock: Fix trace variant formatting Mickaël Salaün
2026-09-07 16:07 ` Mickaël Salaün [this message]
2026-09-11 12:48   ` [PATCH v1 2/2] selftests/landlock: Fix disconnected " Günther Noack
2026-09-11 12:47 ` [PATCH v1 1/2] selftests/landlock: Fix trace " Günther Noack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907160710.126525-2-mic@digikod.net \
    --to=mic@digikod.net \
    --cc=gnoack@google.com \
    --cc=linux-security-module@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.