All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Linus Walleij" <linusw@kernel.org>,
	"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	kernel@pengutronix.de, linux-kernel@vger.kernel.org,
	"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
	"Alvin Šipraga" <alvin.sipraga@analog.com>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/2] net: dsa: realtek: rtl8365mb: add EEE support
Date: Mon, 7 Sep 2026 17:37:02 -0700	[thread overview]
Message-ID: <20260907173702.32b6dd2b@kernel.org> (raw)
In-Reply-To: <20260903092211.2922058-3-o.rempel@pengutronix.de>

On Thu,  3 Sep 2026 11:22:11 +0200 Oleksij Rempel wrote:
> Add EEE support on the integrated-PHY ports, controllable per port via
> ethtool.

Looks like clang is doing more aggressive inlining here because build
fails with:

../drivers/net/dsa/realtek/rtl8365mb_main.c:894:9: error: call to '__compiletime_assert_1481' declared with 'error' attribute: FIELD_PREP: value too large for the field
  894 |         val |= FIELD_PREP(RTL8365MB_INDIRECT_ACCESS_ADDRESS_OCPADR_5_1_MASK,
      |                ^
../include/linux/bitfield.h:138:3: note: expanded from macro 'FIELD_PREP'
  138 |                 __FIELD_PREP(_mask, _val, "FIELD_PREP: ");              \
      |                 ^
../include/linux/bitfield.h:91:3: note: expanded from macro '__FIELD_PREP'
   91 |                 __BF_FIELD_CHECK_MASK(mask, val, pfx);                  \
      |                 ^
../include/linux/bitfield.h:70:3: note: expanded from macro '__BF_FIELD_CHECK_MASK'
   70 |                 BUILD_BUG_ON_MSG(__builtin_constant_p(_val) ?           \
      |                 ^
note: (skipping 2 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
./../include/linux/compiler_types.h:690:2: note: expanded from macro '_compiletime_assert'
  690 |         __compiletime_assert(condition, msg, prefix, suffix)
      |         ^
./../include/linux/compiler_types.h:683:4: note: expanded from macro '__compiletime_assert'
  683 |                         prefix ## suffix();                             \
      |                         ^
<scratch space>:18:1: note: expanded from here
   18 | __compiletime_assert_1481
      | ^

Looks legit at a glance. Maybe the addrs you're defining should be
relative to RTL8365MB_PHY_OCP_ADDR_PHYREG_BASE ?

      parent reply	other threads:[~2026-09-08  0:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  9:22 [PATCH net-next v2 0/2] net: dsa: realtek: EEE support for RTL8365MB-VC Oleksij Rempel
2026-09-03  9:22 ` [PATCH net-next v2 1/2] net: phy: realtek: use C45 for RTL8365MB-VC internal PHY MMD access Oleksij Rempel
2026-09-04 14:12   ` Luiz Angelo Daros de Luca
2026-09-04 22:33   ` Linus Walleij
2026-09-03  9:22 ` [PATCH net-next v2 2/2] net: dsa: realtek: rtl8365mb: add EEE support Oleksij Rempel
2026-09-03 12:24   ` Andrew Lunn
2026-09-04 14:10     ` Luiz Angelo Daros de Luca
2026-09-04 22:33   ` Linus Walleij
2026-09-08  0:37   ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260907173702.32b6dd2b@kernel.org \
    --to=kuba@kernel.org \
    --cc=a.fatoum@pengutronix.de \
    --cc=alvin.sipraga@analog.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kernel@pengutronix.de \
    --cc=linusw@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luizluca@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.