Re: [PATCH v1 4/5] ASoC: dt-bindings: qcom,sm8250: Add Nord Ride sound card

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Casting `clk_disable_unprepare` to `(void (*)(void *))` causes a Control Flow Integrity (CFI) violation when the cleanup action is executed.
--

commit a3caa5181a58d82be436be2044f000032a4ea1ab
Author: Mohammad Rafi Shaik <mohammad.rafi.shaik@oss.qualcomm.com>

ASoC: dt-bindings: qcom,sm8250: Add Nord Ride sound card
    
Document the bindings for the Qualcomm Nord Ride board specific sound card.
The bindings are the same as for other newer Qualcomm ADSP sound cards, thus
keep them in existing qcom,sm8250.yaml file.

> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> index 1536fcd96d687..bdbaa8c822fcd 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
> @@ -38,6 +38,7 @@ properties:
>            - fairphone,fp5-sndcard
>            - qcom,apq8096-sndcard
>            - qcom,glymur-sndcard
> +          - qcom,nord-ride-sndcard
>            - qcom,qcm6490-idp-sndcard
>            - qcom,qcs615-sndcard
>            - qcom,qcs6490-rb3gen2-sndcard

[Severity: High]
Does casting clk_disable_unprepare to (void (*)(void *)) cause a Control Flow
Integrity (CFI) violation when the cleanup action is executed?

Looking at pcm1681_i2c_probe() in sound/soc/codecs/pcm1681.c:

sound/soc/codecs/pcm1681.c:pcm1681_i2c_probe() {
    ...
	ret = devm_add_action_or_reset(&client->dev,
				       (void (*)(void *))clk_disable_unprepare,
				       priv->sclk);
    ...
}

Because clk_disable_unprepare() takes a struct clk *, casting it to
void (*)(void *) and registering it as a devm action means the type hashes
will not match on kernels built with CONFIG_CFI_CLANG.

When the device is unbound (which can happen naturally if a subsequent step
in the probe path fails, or by an administrator via sysfs), the devres
cleanup indirectly calls this action. Can this trigger a CFI panic during
cleanup?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260907-nord-asoc-driver-support-v1-0-997d3b20cf43@oss.qualcomm.com?part=4